Quoting Tvrtko Ursulin (2019-04-17 10:40:26)
>
> On 17/04/2019 08:56, Chris Wilson wrote:
> > +/*
> > + * Powergating configuration for a particular (context,engine).
> > + */
> > +struct intel_sseu {
> > + u8 slice_mask;
> > + u8 subslice_mask;
> > + u8 min_eus_per_subslice;
> > + u8 max_eus_per_subslice;
> > +};
> > +
> > +static inline struct intel_sseu
> > +intel_device_default_sseu(const struct sseu_dev_info *sseu)
>
> As said before, if you rename this function to intel_device_sseu,
> intel_convert_device_sseu, or something, I would be fine with the patch.
> Basically I object to the default in the name since the sseu is passed
> in and could be any.
I didn't understand that was the objection. I thought you were
complaining about storing the default on the engine rather than pulling
it from i915->runtime_info.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
