== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev4) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4a9806c7e6fe drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() 0ba328ef9996 drm/fb-helper: Avoid race with DRM userspace faf3b22de68a drm/fb-helper: No need to cache rotation and sw_rotations 433f6bb5a950 drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode} 6877829f5db8 drm/fb-helper: Remove drm_fb_helper_crtc -:127: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #127: new file mode 100644 -:204: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #204: FILE: drivers/gpu/drm/drm_client_modeset.c:73: +} +/* TODO: Remove export when modeset code has been moved over */ -:234: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #234: FILE: drivers/gpu/drm/drm_client_modeset.c:103: +} +/* TODO: Remove export when modeset code has been moved over */ -:928: WARNING:LONG_LINE: line over 100 characters #928: FILE: drivers/gpu/drm/drm_fb_helper.c:2755: + if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS || -:929: WARNING:LONG_LINE: line over 100 characters #929: FILE: drivers/gpu/drm/drm_fb_helper.c:2756: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) -:1063: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'modeset' - possible side-effects? #1063: FILE: include/drm/drm_client.h:164: +#define drm_client_for_each_modeset(modeset, client) \ + for (({ lockdep_assert_held(&(client)->modeset_mutex); }), \ + modeset = (client)->modesets; modeset->crtc; modeset++) -:1063: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'client' - possible side-effects? #1063: FILE: include/drm/drm_client.h:164: +#define drm_client_for_each_modeset(modeset, client) \ + for (({ lockdep_assert_held(&(client)->modeset_mutex); }), \ + modeset = (client)->modesets; modeset->crtc; modeset++) total: 0 errors, 3 warnings, 4 checks, 962 lines checked fc2de5684c87 drm/fb-helper: Prepare to move out commit code e7bc8d3f4204 drm/fb-helper: Move out commit code -:152: WARNING:LONG_LINE: line over 100 characters #152: FILE: drivers/gpu/drm/drm_client_modeset.c:223: + struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc); -:285: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #285: FILE: drivers/gpu/drm/drm_client_modeset.c:356: + drm_object_property_set_value(&connector->base, + dev->mode_config.dpms_property, dpms_mode); total: 0 errors, 1 warnings, 1 checks, 610 lines checked f4c1616a9e77 drm/fb-helper: Remove drm_fb_helper_connector -:588: WARNING:LONG_LINE: line over 100 characters #588: FILE: drivers/gpu/drm/drm_fb_helper.c:1959: + connector->base.id, connector->tile_group ? connector->tile_group->id : 0); -:945: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #945: FILE: include/drm/drm_client.h:183: +#define drm_client_for_each_connector_iter(connector, iter) \ + drm_for_each_connector_iter(connector, iter) \ + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) -:945: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'connector' - possible side-effects? #945: FILE: include/drm/drm_client.h:183: +#define drm_client_for_each_connector_iter(connector, iter) \ + drm_for_each_connector_iter(connector, iter) \ + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) total: 1 errors, 1 warnings, 1 checks, 1006 lines checked d349e5c6cae5 drm/fb-helper: Prepare to move out modeset config code -:169: WARNING:LONG_LINE: line over 100 characters #169: FILE: drivers/gpu/drm/drm_fb_helper.c:2351: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) { total: 0 errors, 1 warnings, 0 checks, 179 lines checked eaf53f44dd76 drm/fb-helper: Move out modeset config code -:99: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #99: FILE: drivers/gpu/drm/drm_client_modeset.c:140: + if (cmdline_mode->specified == false) -:170: WARNING:LONG_LINE: line over 100 characters #170: FILE: drivers/gpu/drm/drm_client_modeset.c:211: + connector->display_info.non_desktop ? "non desktop" : enabled[i] ? "yes" : "no"); -:314: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #314: FILE: drivers/gpu/drm/drm_client_modeset.c:355: + if (enabled[i] == false) { -:348: WARNING:LONG_LINE: line over 100 characters #348: FILE: drivers/gpu/drm/drm_client_modeset.c:389: + connector->base.id, connector->tile_group ? connector->tile_group->id : 0); -:404: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!modes[n]" #404: FILE: drivers/gpu/drm/drm_client_modeset.c:445: + if (modes[n] == NULL) -:735: WARNING:LONG_LINE: line over 100 characters #735: FILE: drivers/gpu/drm/drm_client_modeset.c:776: + if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS || -:736: WARNING:LONG_LINE: line over 100 characters #736: FILE: drivers/gpu/drm/drm_client_modeset.c:777: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) { -:1494: WARNING:LONG_LINE: line over 100 characters #1494: FILE: include/drm/drm_client.h:155: +int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, unsigned int height); total: 0 errors, 5 warnings, 3 checks, 1463 lines checked 9bbead190cb6 drm/client: Hack: Add bootsplash example -:28: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #28: FILE: drivers/gpu/drm/Kconfig:68: +config DRM_CLIENT_BOOTSPLASH -:49: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 -:54: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #54: FILE: drivers/gpu/drm/drm_bootsplash.c:1: +/* DRM internal client example */ -:80: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #80: FILE: drivers/gpu/drm/drm_bootsplash.c:27: + struct mutex lock; -:120: WARNING:LONG_LINE: line over 100 characters #120: FILE: drivers/gpu/drm/drm_bootsplash.c:67: + splash->buffers[i] = drm_client_framebuffer_create(&splash->client, width, height, DRM_FORMAT_XRGB8888); -:270: WARNING:LONG_LINE: line over 100 characters #270: FILE: drivers/gpu/drm/drm_bootsplash.c:217: +static int drm_bootsplash_draw(struct drm_bootsplash *splash, unsigned int sequence, unsigned int buffer_num) total: 0 errors, 5 warnings, 1 checks, 416 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
