== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev6) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4912527e1aba drm/i915: Introduce vfunc intel_get_color_config to create hw lut 0bfa41d5f0d7 drm/i915: Enable intel_color_get_config() c4668870f66f drm/i915: Extract i9xx_get_color_config() -:70: WARNING:LONG_LINE: line over 100 characters #70: FILE: drivers/gpu/drm/i915/intel_color.c:1268: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_RED_MASK, val), 8); -:71: WARNING:LONG_LINE: line over 100 characters #71: FILE: drivers/gpu/drm/i915/intel_color.c:1269: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_GREEN_MASK, val), 8); -:72: WARNING:LONG_LINE: line over 100 characters #72: FILE: drivers/gpu/drm/i915/intel_color.c:1270: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_BLUE_MASK, val), 8); total: 0 errors, 3 warnings, 0 checks, 71 lines checked 5d9703416dc0 drm/i915: Extract cherryview_get_color_config() -:53: WARNING:LONG_LINE: line over 100 characters #53: FILE: drivers/gpu/drm/i915/intel_color.c:1300: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_GREEN_MASK, val), 10); -:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/intel_color.c:1301: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_BLUE_MASK, val), 10); -:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/intel_color.c:1304: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_RED_MASK, val), 10); total: 0 errors, 3 warnings, 0 checks, 59 lines checked d60da8743997 drm/i915: Extract i965_get_color_config() -:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/intel_color.c:1339: + blob_data[i].red = REG_FIELD_GET(PALETTE_RED_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_RED_MASK, val2); -:56: WARNING:LONG_LINE: line over 100 characters #56: FILE: drivers/gpu/drm/i915/intel_color.c:1340: + blob_data[i].green = REG_FIELD_GET(PALETTE_GREEN_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_GREEN_MASK, val2); -:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/intel_color.c:1341: + blob_data[i].blue = REG_FIELD_GET(PALETTE_BLUE_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_BLUE_MASK, val2) ; -:57: WARNING:SPACING: space prohibited before semicolon #57: FILE: drivers/gpu/drm/i915/intel_color.c:1341: + blob_data[i].blue = REG_FIELD_GET(PALETTE_BLUE_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_BLUE_MASK, val2) ; total: 0 errors, 4 warnings, 0 checks, 59 lines checked 3de95a9fd6c4 drm/i915: Extract icl_get_color_config() -:35: ERROR:CODE_INDENT: code indent should use tabs where possible #35: FILE: drivers/gpu/drm/i915/intel_color.c:1356: +^I^I^I u32 prec_index)$ -:35: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #35: FILE: drivers/gpu/drm/i915/intel_color.c:1356: +static void bdw_get_gamma_config(struct intel_crtc_state *crtc_state, + u32 prec_index) -:59: WARNING:LONG_LINE: line over 100 characters #59: FILE: drivers/gpu/drm/i915/intel_color.c:1380: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_RED_MASK, val), 10); -:60: WARNING:LONG_LINE: line over 100 characters #60: FILE: drivers/gpu/drm/i915/intel_color.c:1381: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_GREEN_MASK, val), 10); -:61: WARNING:LONG_LINE: line over 100 characters #61: FILE: drivers/gpu/drm/i915/intel_color.c:1382: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_BLUE_MASK, val), 10); -:86: CHECK:BRACES: braces {} should be used on all arms of this statement #86: FILE: drivers/gpu/drm/i915/intel_color.c:1440: + if (INTEL_GEN(dev_priv) >= 11) { [...] else if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv)) [...] total: 1 errors, 3 warnings, 2 checks, 70 lines checked 072235c17597 drm/i915: Extract glk_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 26 lines checked fa8d86057b5c drm/i915: Extract bdw_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 29 lines checked 17c09be650d6 drm/i915: Extract ivb_get_color_config() -:21: ERROR:CODE_INDENT: code indent should use tabs where possible #21: FILE: drivers/gpu/drm/i915/intel_color.c:1419: +^I^I^I u32 prec_index)$ -:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #21: FILE: drivers/gpu/drm/i915/intel_color.c:1419: +static void ivb_get_gamma_config(struct intel_crtc_state *crtc_state, + u32 prec_index) -:43: WARNING:LONG_LINE: line over 100 characters #43: FILE: drivers/gpu/drm/i915/intel_color.c:1441: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_RED_MASK, val), 10); -:44: WARNING:LONG_LINE: line over 100 characters #44: FILE: drivers/gpu/drm/i915/intel_color.c:1442: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_GREEN_MASK, val), 10); -:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/intel_color.c:1443: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_BLUE_MASK, val), 10); total: 1 errors, 3 warnings, 1 checks, 62 lines checked b880360402ee drm/i915: Extract ilk_get_color_config() -:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/intel_color.c:1482: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_RED_MASK, val), 10); -:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/intel_color.c:1483: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_GREEN_MASK, val), 10); -:56: WARNING:LONG_LINE: line over 100 characters #56: FILE: drivers/gpu/drm/i915/intel_color.c:1484: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_BLUE_MASK, val), 10); total: 0 errors, 3 warnings, 0 checks, 63 lines checked db98bed6746b drm/i915: Add intel_color_lut_equal() to compare hw and sw gamma lut values -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: -Corrected smatch warn "variable dereferenced before check" (Dan Carpenter) -:22: WARNING:LONG_LINE: line over 100 characters #22: FILE: drivers/gpu/drm/i915/intel_color.c:1498: +static inline bool gamma_err_check(struct drm_color_lut *sw_lut, struct drm_color_lut *hw_lut, u32 err) -:24: WARNING:TABSTOP: Statements should start on a tabstop #24: FILE: drivers/gpu/drm/i915/intel_color.c:1500: + return ((abs((long)hw_lut->red - sw_lut->red)) >= err) || -:25: ERROR:CODE_INDENT: code indent should use tabs where possible #25: FILE: drivers/gpu/drm/i915/intel_color.c:1501: +^I ((abs((long)hw_lut->blue - sw_lut->blue)) >= err) ||$ -:26: ERROR:CODE_INDENT: code indent should use tabs where possible #26: FILE: drivers/gpu/drm/i915/intel_color.c:1502: +^I ((abs((long)hw_lut->green - sw_lut->green)) >= err);$ -:43: ERROR:SPACING: space required before the open parenthesis '(' #43: FILE: drivers/gpu/drm/i915/intel_color.c:1519: + switch(gamma_mode) { -:64: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17) #64: FILE: drivers/gpu/drm/i915/intel_color.c:1540: + for (i = 0; i < sw_lut_size; i++) { + if (!gamma_err_check(&hw_lut[i], &sw_lut[i], err)) -:65: WARNING:TABSTOP: Statements should start on a tabstop #65: FILE: drivers/gpu/drm/i915/intel_color.c:1541: + if (!gamma_err_check(&hw_lut[i], &sw_lut[i], err)) -:83: CHECK:LINE_SPACING: Please don't use multiple blank lines #83: FILE: drivers/gpu/drm/i915/intel_color.h:9: + -:108: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #108: FILE: drivers/gpu/drm/i915/intel_display.c:12240: +#define PIPE_CONF_CHECK_COLOR_LUT(name, gamma_mode) do { \ + if (!intel_color_lut_equal(current_config->name, pipe_config->name, gamma_mode)) { \ + pipe_config_err(adjust, __stringify(name), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ +} while (0) -:108: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #108: FILE: drivers/gpu/drm/i915/intel_display.c:12240: +#define PIPE_CONF_CHECK_COLOR_LUT(name, gamma_mode) do { \ + if (!intel_color_lut_equal(current_config->name, pipe_config->name, gamma_mode)) { \ + pipe_config_err(adjust, __stringify(name), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ +} while (0) total: 3 errors, 5 warnings, 3 checks, 98 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
