On Wed, 21 Mar 2012 22:09:48 -0300, Eugeni Dodonov <eugeni.dodonov at intel.com> wrote: > With Lynx Point, we need to use SBI to communicate with the display clock > control. This commit adds helper functions to access the registers via > SBI. > > Signed-off-by: Eugeni Dodonov <eugeni.dodonov at intel.com> > --- > drivers/gpu/drm/i915/intel_display.c | 44 ++++++++++++++++++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index de1ba19..c225de4 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -1198,6 +1198,50 @@ static void intel_disable_pll(struct drm_i915_private *dev_priv, enum pipe pipe) > POSTING_READ(reg); > } > > +/* SBI access */ > +static inline void > +SBI_WRITE(struct drm_i915_private *dev_priv, u16 reg, u32 value) These are too big and too frequent to be inlined. At least that means we won't have to shout! -Chris -- Chris Wilson, Intel Open Source Technology Centre