Quoting Ville Syrjala (2019-04-15 16:49:02) > static void ibx_irq_handler(struct drm_i915_private *dev_priv, u32 pch_iir) > { > + struct hpd_irq_regs hpd = {}; Is unnecessary, right? hpd.hotplug_trigger is set here, and .dig_hotplug_reg immediately after by irq_ack. So other than those extra clears, it looks straightforward enough. Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx