From: Alastair D'Silva > Sent: 15 April 2019 11:45 ... > > Although I think you'd want a 'no hex' flag to suppress the hex. > > > > Probably more useful flags are ones to suppress the address column. > > This is already supported by the prefix_type parameter - are you proposing that we eliminate the > parameter & combine it with flags? I was looking at the flags on one of my hexdump() functions... > > I've also used flags to enable (or disable) suppression of multiple lines of > > zeros of constant bytes. > > In that case you may want hexdump to return the flags for the next call when > > a large buffer is being dumped in fragments. > > I'm afraid I don't quite follow here, hex_dump_to_buffer doesn't alter the flags, > so the caller already knows it. If you are suppressing lines of zeros and dumping a buffer in several blocks then subsequent calls need to know that the last line of the previous call was suppressed zeros - and carry on with the same suppressed block. I've not looked to see if it does support suppressing lines of zeros/0xff. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
