== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev4) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 37affd023b33 drm/i915: Introduce vfunc intel_get_color_config to create hw lut 2c1fbf49d4d5 drm/i915: Extract i9xx_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:67: WARNING:LONG_LINE: line over 100 characters #67: FILE: drivers/gpu/drm/i915/intel_color.c:1268: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_RED_MASK, val) >> 16, 8); -:68: WARNING:LONG_LINE: line over 100 characters #68: FILE: drivers/gpu/drm/i915/intel_color.c:1269: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_GREEN_MASK, val) >> 8, 8); -:69: WARNING:LONG_LINE: line over 100 characters #69: FILE: drivers/gpu/drm/i915/intel_color.c:1270: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(LGC_PALETTE_BLUE_MASK, val), 8); total: 0 errors, 4 warnings, 0 checks, 72 lines checked ed916c9dbb95 drm/i915: Extract cherryview_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:50: WARNING:LONG_LINE: line over 100 characters #50: FILE: drivers/gpu/drm/i915/intel_color.c:1301: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_GREEN_MASK, val) >> 16, 10); -:51: WARNING:LONG_LINE: line over 100 characters #51: FILE: drivers/gpu/drm/i915/intel_color.c:1302: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_BLUE_MASK, val), 10); -:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/intel_color.c:1305: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(CGM_PIPE_GAMMA_RED_MASK, val), 10); total: 0 errors, 4 warnings, 0 checks, 60 lines checked 4e1026ef5692 drm/i915: Extract i965_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:52: WARNING:LONG_LINE: line over 100 characters #52: FILE: drivers/gpu/drm/i915/intel_color.c:1341: + blob_data[i].red = (REG_FIELD_GET(PALETTE_RED_MASK, val1) >> 16) << 8 | (REG_FIELD_GET(PALETTE_RED_MASK, val2) >> 16); -:53: WARNING:LONG_LINE: line over 100 characters #53: FILE: drivers/gpu/drm/i915/intel_color.c:1342: + blob_data[i].green = (REG_FIELD_GET(PALETTE_GREEN_MASK, val1) >> 8) << 8 | (REG_FIELD_GET(PALETTE_GREEN_MASK, val2) >> 8); -:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/intel_color.c:1343: + blob_data[i].blue = REG_FIELD_GET(PALETTE_BLUE_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_BLUE_MASK, val2) ; -:54: WARNING:SPACING: space prohibited before semicolon #54: FILE: drivers/gpu/drm/i915/intel_color.c:1343: + blob_data[i].blue = REG_FIELD_GET(PALETTE_BLUE_MASK, val1) << 8 | REG_FIELD_GET(PALETTE_BLUE_MASK, val2) ; total: 0 errors, 5 warnings, 0 checks, 60 lines checked 950b0424cebd drm/i915: Extract icl_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:31: ERROR:CODE_INDENT: code indent should use tabs where possible #31: FILE: drivers/gpu/drm/i915/intel_color.c:1358: +^I^I^I u32 prec_index)$ -:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #31: FILE: drivers/gpu/drm/i915/intel_color.c:1358: +static void bdw_get_gamma_config(struct intel_crtc_state *crtc_state, + u32 prec_index) -:56: WARNING:LONG_LINE: line over 100 characters #56: FILE: drivers/gpu/drm/i915/intel_color.c:1383: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_RED_MASK, val) >> 20, 10); -:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/intel_color.c:1384: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_GREEN_MASK, val) >> 10, 10); -:58: WARNING:LONG_LINE: line over 100 characters #58: FILE: drivers/gpu/drm/i915/intel_color.c:1385: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_BLUE_MASK, val), 10); -:83: CHECK:BRACES: braces {} should be used on all arms of this statement #83: FILE: drivers/gpu/drm/i915/intel_color.c:1443: + if (INTEL_GEN(dev_priv) >= 11) { [...] else if (IS_CANNONLAKE(dev_priv) || IS_GEMINILAKE(dev_priv)) [...] total: 1 errors, 4 warnings, 2 checks, 71 lines checked f0350da652e9 drm/i915: Extract glk_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 26 lines checked 6cd82ce2f4a1 drm/i915: Extract bdw_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 29 lines checked 85fd57b4994b drm/i915: Extract ivb_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:17: ERROR:CODE_INDENT: code indent should use tabs where possible #17: FILE: drivers/gpu/drm/i915/intel_color.c:1422: +^I^I^I u32 prec_index)$ -:17: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #17: FILE: drivers/gpu/drm/i915/intel_color.c:1422: +static void ivb_get_gamma_config(struct intel_crtc_state *crtc_state, + u32 prec_index) -:40: WARNING:LONG_LINE: line over 100 characters #40: FILE: drivers/gpu/drm/i915/intel_color.c:1445: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_RED_MASK, val) >> 20, 10); -:41: WARNING:LONG_LINE: line over 100 characters #41: FILE: drivers/gpu/drm/i915/intel_color.c:1446: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_GREEN_MASK, val) >> 10, 10); -:42: WARNING:LONG_LINE: line over 100 characters #42: FILE: drivers/gpu/drm/i915/intel_color.c:1447: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PAL_DATA_BLUE_MASK, val), 10); total: 1 errors, 4 warnings, 1 checks, 63 lines checked c4b9331e9b26 drm/i915: Extract ilk_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one -:51: WARNING:LONG_LINE: line over 100 characters #51: FILE: drivers/gpu/drm/i915/intel_color.c:1487: + blob_data[i].red = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_RED_MASK, val) >> 20, 10); -:52: WARNING:LONG_LINE: line over 100 characters #52: FILE: drivers/gpu/drm/i915/intel_color.c:1488: + blob_data[i].green = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_GREEN_MASK, val) >> 10, 10); -:53: WARNING:LONG_LINE: line over 100 characters #53: FILE: drivers/gpu/drm/i915/intel_color.c:1489: + blob_data[i].blue = intel_color_lut_pack(REG_FIELD_GET(PREC_PALETTE_BLUE_MASK, val), 10); total: 0 errors, 4 warnings, 0 checks, 64 lines checked b4e5942038d9 drm/i915: Enable intel_get_color_config() -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 21 lines checked 4d127259db0f drm/i915: Add intel_compare_color_lut() to compare hw and sw gamma lut values -:19: WARNING:LONG_LINE: line over 100 characters #19: FILE: drivers/gpu/drm/i915/intel_color.c:1503: +static inline bool gamma_err_check(struct drm_color_lut *sw_lut, struct drm_color_lut *hw_lut, u32 err) -:21: WARNING:TABSTOP: Statements should start on a tabstop #21: FILE: drivers/gpu/drm/i915/intel_color.c:1505: + return ((abs((long)hw_lut->red - sw_lut->red)) >= err) || -:22: ERROR:CODE_INDENT: code indent should use tabs where possible #22: FILE: drivers/gpu/drm/i915/intel_color.c:1506: +^I ((abs((long)hw_lut->blue - sw_lut->blue)) >= err) ||$ -:23: ERROR:CODE_INDENT: code indent should use tabs where possible #23: FILE: drivers/gpu/drm/i915/intel_color.c:1507: +^I ((abs((long)hw_lut->green - sw_lut->green)) >= err);$ -:38: ERROR:SPACING: space required before the open parenthesis '(' #38: FILE: drivers/gpu/drm/i915/intel_color.c:1522: + switch(gamma_mode) { -:60: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 17) #60: FILE: drivers/gpu/drm/i915/intel_color.c:1544: + for (i = 0; i < sw_lut_size; i++) { + if (!gamma_err_check(&hw_lut[i], &sw_lut[i], err)) -:61: WARNING:TABSTOP: Statements should start on a tabstop #61: FILE: drivers/gpu/drm/i915/intel_color.c:1545: + if (!gamma_err_check(&hw_lut[i], &sw_lut[i], err)) -:103: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects? #103: FILE: drivers/gpu/drm/i915/intel_display.c:12240: +#define PIPE_CONF_CHECK_COLOR_LUT(name, gamma_mode) do { \ + if (!intel_compare_color_lut(current_config->name, pipe_config->name, gamma_mode)) { \ + pipe_config_err(adjust, __stringify(name), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ +} while (0) -:103: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues #103: FILE: drivers/gpu/drm/i915/intel_display.c:12240: +#define PIPE_CONF_CHECK_COLOR_LUT(name, gamma_mode) do { \ + if (!intel_compare_color_lut(current_config->name, pipe_config->name, gamma_mode)) { \ + pipe_config_err(adjust, __stringify(name), \ + "hw_state doesn't match sw_state\n"); \ + ret = false; \ + } \ +} while (0) total: 3 errors, 4 warnings, 2 checks, 96 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
