Re: [PATCH] drm/i915: Call i915_sw_fence_fini on request cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v5.1-rc4 next-20190410]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Call-i915_sw_fence_fini-on-request-cleanup/20190411-205947
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/i915_request.c: In function 'i915_fence_release':
>> drivers/gpu//drm/i915/i915_request.c:104:24: error: 'struct i915_request' has no member named 'semaphore'
     i915_sw_fence_fini(&rq->semaphore);
                           ^~

vim +104 drivers/gpu//drm/i915/i915_request.c

    91	
    92	static void i915_fence_release(struct dma_fence *fence)
    93	{
    94		struct i915_request *rq = to_request(fence);
    95	
    96		/*
    97		 * The request is put onto a RCU freelist (i.e. the address
    98		 * is immediately reused), mark the fences as being freed now.
    99		 * Otherwise the debugobjects for the fences are only marked as
   100		 * freed when the slab cache itself is freed, and so we would get
   101		 * caught trying to reuse dead objects.
   102		 */
   103		i915_sw_fence_fini(&rq->submit);
 > 104		i915_sw_fence_fini(&rq->semaphore);
   105	
   106		kmem_cache_free(global.slab_requests, rq);
   107	}
   108	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux