On 11/04/2019 13:32, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-04-11 13:26:54)
From: Andi Shyti <andi.shyti@xxxxxxxxx>
Replace the legacy for_each_engine* defines with the ones
implemented in the gem_engine_topology library.
Use whenever possible gem_engine_can_store_dword() that checks
class instead of flags.
Now the __for_each_engine_class_instance and
for_each_engine_class_instance are unused, remove them.
Suggested-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
I see a lot of new gem_context_create(), but not gem_require_contexts().
Problem is __for_each_physical_engine modifies the default context so
tests under that iterator can't keep using I915_EXEC_RENDER.
It was perhaps a knee-jerk reaction to make them create their own
context as a workaround.
Should we have a helper after all to get eb flags for given class:instance?
unsigned int
gem_get_ctx_eb_flags(uint32_t ctx, uint16_t class, uint16_t instance)
{
if (ctx.has_map)
return find_class_instance_in_map->flags;
else
return gem_class_instance_to_eb_flags(class, instance);
}
?
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
