>-----Original Message----- >From: Sam Ravnborg [mailto:sam@xxxxxxxxxxxx] >Sent: Tuesday, April 2, 2019 12:07 AM >To: Shankar, Uma <uma.shankar@xxxxxxxxx> >Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; >dcastagna@xxxxxxxxxxxx; emil.l.velikov@xxxxxxxxx; seanpaul@xxxxxxxxxxxx; >Syrjala, Ville <ville.syrjala@xxxxxxxxx>; Lankhorst, Maarten ><maarten.lankhorst@xxxxxxxxx> >Subject: Re: [v2 3/7] drm: Add gamma mode property > >Hi Uma. > >> --- a/include/drm/drm_crtc.h >> +++ b/include/drm/drm_crtc.h >> @@ -256,6 +256,13 @@ struct drm_crtc_state { >> struct drm_property_blob *gamma_mode_caps; >> >> /** >> + * @gamma_mode: >> + * >> + * FIXME >> + */ >> + struct drm_property_blob *gamma_mode; > >HEre the name matches, but please add documentation too. Sure, will add documentation explaining how this should get used once we have the agreement on design and approach. >> >> +struct drm_color_mode_lut { >> + /* DRM_MODE_LUT_* */ >> + __u32 flags; >> + /* number of points on the curve */ >> + __u32 count; >> + /* Name of Gamma Mode */ >> + char name[DRM_PROP_NAME_LEN]; >> + /* Pointer to Lut elements */ >> + __u64 lut; >> +}; >From an alignment point of view the __u64 should come before the char name[]. >But the above may be fine depending on DRM_PROP_NAME_LEN Yeah, but can re-order this. Thanks for the review. Regards, Uma Shankar > > Sam _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
