Hi Chris, Thank you for the patch! Yet something to improve: [auto build test ERROR on sound/for-next] [also build test ERROR on v5.1-rc4 next-20190405] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/snd-hda-Detangle-unwind-to-avoid-double-release-of-display-powerwell/20190408-185235 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: i386-randconfig-x012-201914 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): sound/pci/hda/hda_intel.c: In function 'azx_probe_continue': >> sound/pci/hda/hda_intel.c:2252:4: error: label 'power' used but not defined goto power; ^~~~ vim +/power +2252 sound/pci/hda/hda_intel.c 2231 2232 /* create codec instances */ 2233 err = azx_probe_codecs(chip, azx_max_codecs[chip->driver_type]); 2234 if (err < 0) 2235 goto power; 2236 2237 #ifdef CONFIG_SND_HDA_PATCH_LOADER 2238 if (chip->fw) { 2239 err = snd_hda_load_patch(&chip->bus, chip->fw->size, 2240 chip->fw->data); 2241 if (err < 0) 2242 goto power; 2243 #ifndef CONFIG_PM 2244 release_firmware(chip->fw); /* no longer needed */ 2245 chip->fw = NULL; 2246 #endif 2247 } 2248 #endif 2249 if ((probe_only[dev] & 1) == 0) { 2250 err = azx_codec_configure(chip); 2251 if (err < 0) > 2252 goto power; 2253 } 2254 2255 err = snd_card_register(chip->card); 2256 if (err < 0) 2257 goto out_power; 2258 2259 setup_vga_switcheroo_runtime_pm(chip); 2260 2261 chip->running = 1; 2262 azx_add_card_list(chip); 2263 2264 set_default_power_save(chip); 2265 2266 if (azx_has_pm_runtime(chip)) 2267 pm_runtime_put_autosuspend(&pci->dev); 2268 2269 out_power: 2270 if (err < 0 || !hda->need_i915_power) 2271 display_power(chip, false); 2272 out_free: 2273 if (err < 0) 2274 hda->init_failed = 1; 2275 complete_all(&hda->probe_wait); 2276 to_hda_bus(bus)->bus_probing = 0; 2277 return err; 2278 } 2279 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
