== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev2) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 60e07d9925cc drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() 0b30c352ab25 drm/fb-helper: Avoid race with DRM userspace 0fbd680b5973 drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper 92a17a2eaf09 drm/fb-helper: No need to cache rotation and sw_rotations c29ff7942699 drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode} bbe8261ada7c drm/fb-helper: Remove drm_fb_helper_crtc -:104: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #104: new file mode 100644 -:209: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #209: FILE: drivers/gpu/drm/drm_client_modeset.c:101: +} +/* TODO: Remove export when modeset code has been moved over */ -:903: WARNING:LONG_LINE: line over 100 characters #903: FILE: drivers/gpu/drm/drm_fb_helper.c:2755: + if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS || -:904: WARNING:LONG_LINE: line over 100 characters #904: FILE: drivers/gpu/drm/drm_fb_helper.c:2756: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) -:1037: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'modeset' - possible side-effects? #1037: FILE: include/drm/drm_client.h:163: +#define drm_client_for_each_modeset(modeset, client) \ + for (modeset = (client)->modesets; modeset && modeset->crtc; modeset++) total: 0 errors, 3 warnings, 2 checks, 946 lines checked 4f0a9df0c515 drm/fb-helper: Prepare to move out commit code 9f4f3682bd7b drm/fb-helper: Move out commit code -:152: WARNING:LONG_LINE: line over 100 characters #152: FILE: drivers/gpu/drm/drm_client_modeset.c:221: + struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, crtc); -:285: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #285: FILE: drivers/gpu/drm/drm_client_modeset.c:354: + drm_object_property_set_value(&connector->base, + dev->mode_config.dpms_property, dpms_mode); total: 0 errors, 1 warnings, 1 checks, 610 lines checked e9458956045c drm/fb-helper: Remove drm_fb_helper_connector -:588: WARNING:LONG_LINE: line over 100 characters #588: FILE: drivers/gpu/drm/drm_fb_helper.c:1959: + connector->base.id, connector->tile_group ? connector->tile_group->id : 0); -:945: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #945: FILE: include/drm/drm_client.h:181: +#define drm_client_for_each_connector_iter(connector, iter) \ + drm_for_each_connector_iter(connector, iter) \ + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) -:945: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'connector' - possible side-effects? #945: FILE: include/drm/drm_client.h:181: +#define drm_client_for_each_connector_iter(connector, iter) \ + drm_for_each_connector_iter(connector, iter) \ + if (connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK) total: 1 errors, 1 warnings, 1 checks, 1006 lines checked d9c4bc11e19d drm/fb-helper: Prepare to move out modeset config code -:167: WARNING:LONG_LINE: line over 100 characters #167: FILE: drivers/gpu/drm/drm_fb_helper.c:2352: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) { total: 0 errors, 1 warnings, 0 checks, 180 lines checked 0293a7f31f3f drm/fb-helper: Move out modeset config code -:80: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #80: FILE: drivers/gpu/drm/drm_client_modeset.c:140: + if (cmdline_mode->specified == false) -:151: WARNING:LONG_LINE: line over 100 characters #151: FILE: drivers/gpu/drm/drm_client_modeset.c:211: + connector->display_info.non_desktop ? "non desktop" : enabled[i] ? "yes" : "no"); -:295: CHECK:BOOL_COMPARISON: Using comparison to false is error prone #295: FILE: drivers/gpu/drm/drm_client_modeset.c:355: + if (enabled[i] == false) { -:329: WARNING:LONG_LINE: line over 100 characters #329: FILE: drivers/gpu/drm/drm_client_modeset.c:389: + connector->base.id, connector->tile_group ? connector->tile_group->id : 0); -:385: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!modes[n]" #385: FILE: drivers/gpu/drm/drm_client_modeset.c:445: + if (modes[n] == NULL) -:717: WARNING:LONG_LINE: line over 100 characters #717: FILE: drivers/gpu/drm/drm_client_modeset.c:777: + if (WARN_ON_ONCE(modeset->num_connectors == DRM_CLIENT_MAX_CLONED_CONNECTORS || -:718: WARNING:LONG_LINE: line over 100 characters #718: FILE: drivers/gpu/drm/drm_client_modeset.c:778: + (dev->mode_config.num_crtc > 1 && modeset->num_connectors == 1))) { -:1476: WARNING:LONG_LINE: line over 100 characters #1476: FILE: include/drm/drm_client.h:155: +int drm_client_modeset_probe(struct drm_client_dev *client, unsigned int width, unsigned int height); total: 0 errors, 5 warnings, 3 checks, 1448 lines checked 7d54fde89981 drm/client: Hack: Add bootsplash example -:28: WARNING:CONFIG_DESCRIPTION: please write a paragraph that describes the config symbol fully #28: FILE: drivers/gpu/drm/Kconfig:68: +config DRM_CLIENT_BOOTSPLASH -:49: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #49: new file mode 100644 -:54: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #54: FILE: drivers/gpu/drm/drm_bootsplash.c:1: +/* DRM internal client example */ -:80: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #80: FILE: drivers/gpu/drm/drm_bootsplash.c:27: + struct mutex lock; -:120: WARNING:LONG_LINE: line over 100 characters #120: FILE: drivers/gpu/drm/drm_bootsplash.c:67: + splash->buffers[i] = drm_client_framebuffer_create(&splash->client, width, height, DRM_FORMAT_XRGB8888); -:267: WARNING:LONG_LINE: line over 100 characters #267: FILE: drivers/gpu/drm/drm_bootsplash.c:214: +static int drm_bootsplash_draw(struct drm_bootsplash *splash, unsigned int sequence, unsigned int buffer_num) total: 0 errors, 5 warnings, 1 checks, 413 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
