Quoting Imre Deak (2019-04-07 13:06:32) > On Sun, Apr 07, 2019 at 02:55:14PM +0300, Imre Deak wrote: > > > get_power_domains() and atomic needs to take responsibility for the > > > overlapping set of powerwells imo. > > > > ->get_power_domains() is essentially the powerref acquisition part of the > > encoder->get_hw_state(). We have a separate hook for it since the latter > > one is also called during verification, where we don't want to take the > > long time refs (they must have been acquired already by the modeset we > > are verifying). > > Note the similar logic for crtc powerrefs in > intel_modeset_setup_hw_state()/modeset_get_crtc_power_domains(). Hmm. That's what I thought this was. I probably was confusing the paths. Also while you are here, care to look over https://patchwork.freedesktop.org/patch/296632/?series=59089&rev=2 -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx