Re: [PATCH v4] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Aditya,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190403]
[cannot apply to v5.1-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Aditya-Swarup/drm-i915-icl-Set-GCP_COLOR_INDICATION-only-for-10-12-bit-deep-color/20190403-201049
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-8) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/intel_hdmi.c: In function 'intel_hdmi_compute_gcp_infoframe':
>> drivers/gpu//drm/i915/intel_hdmi.c:970:6: error: expected ')' before 'crtc_state'
         crtc_state->pipe_bpp > 24)
         ^~~~~~~~~~

vim +970 drivers/gpu//drm/i915/intel_hdmi.c

   952	
   953	static void intel_hdmi_compute_gcp_infoframe(struct intel_encoder *encoder,
   954						     struct intel_crtc_state *crtc_state,
   955						     struct drm_connector_state *conn_state)
   956	{
   957		struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
   958	
   959		if (IS_G4X(dev_priv) || !crtc_state->has_infoframe)
   960			return;
   961	
   962		crtc_state->infoframes.enable |=
   963			intel_hdmi_infoframe_enable(HDMI_PACKET_TYPE_GENERAL_CONTROL);
   964	
   965		/* Indicate color depth whenever the sink supports deep color
   966		 * Also, 8bpc + color depth indication is no longer supported
   967		 * for HSW+ platforms.
   968		 * */
   969		if (hdmi_sink_is_deep_color(conn_state)
 > 970		    crtc_state->pipe_bpp > 24)
   971			crtc_state->infoframes.gcp |= GCP_COLOR_INDICATION;
   972	
   973		/* Enable default_phase whenever the display mode is suitably aligned */
   974		if (gcp_default_phase_possible(crtc_state->pipe_bpp,
   975					       &crtc_state->base.adjusted_mode))
   976			crtc_state->infoframes.gcp |= GCP_DEFAULT_PHASE_ENABLE;
   977	}
   978	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux