On Wed, Mar 20, 2019 at 2:20 PM Souza, Jose <jose.souza@xxxxxxxxx> wrote: > > On Wed, 2019-03-20 at 14:15 -0700, Bob Paauwe wrote: > > Unlike ICL, all of the output ports are combo phys so just return > > true in intel_port_is_combophy for all EHL ports to indicate that. > > > > v2: Return false in intel_port_is_tc since no EHL ports are TC. > > (Jose) > > Reviewed-by: José Roberto de Souza <jose.souza@xxxxxxxxx> I removed the (v2) from the first line of the commit message since we don't add that normally and pushed. Thanks. Lucas De Marchi > > > > > Cc: Jose Souza <jose.souza@xxxxxxxxx> > > Signed-off-by: Bob Paauwe <bob.j.paauwe@xxxxxxxxx> > > Signed-off-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/intel_display.c | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index 2b25098d47a9..094456843c4a 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > > +++ b/drivers/gpu/drm/i915/intel_display.c > > @@ -6170,6 +6170,9 @@ bool intel_port_is_combophy(struct > > drm_i915_private *dev_priv, enum port port) > > if (port == PORT_NONE) > > return false; > > > > + if (IS_ELKHARTLAKE(dev_priv)) > > + return port <= PORT_C; > > + > > if (INTEL_GEN(dev_priv) >= 11) > > return port <= PORT_B; > > > > @@ -6178,7 +6181,7 @@ bool intel_port_is_combophy(struct > > drm_i915_private *dev_priv, enum port port) > > > > bool intel_port_is_tc(struct drm_i915_private *dev_priv, enum port > > port) > > { > > - if (INTEL_GEN(dev_priv) >= 11) > > + if (INTEL_GEN(dev_priv) >= 11 && !IS_ELKHARTLAKE(dev_priv)) > > return port >= PORT_C && port <= PORT_F; > > > > return false; > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Lucas De Marchi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx