Hi Uma. Noticed a kerneldoc nit while browsign the code. Maybe try to let kernel doc tell you if there are more. Sam > > /** > + * drm_hdmi_infoframe_set_hdr_metadata() - fill an HDMI AVI infoframe with > + * HDR metadata from userspace > + * @frame: HDMI AVI infoframe > + * @hdr_source_metadata: hdr_source_metadata info from userspace Parameter is named hdr_metadata > + * > + * Return: 0 on success or a negative error code on failure. > + */ > +int > +drm_hdmi_infoframe_set_hdr_metadata(struct hdmi_drm_infoframe *frame, > + struct hdr_output_metadata *hdr_metadata) > +{ > + > +/** > + * hdmi_drm_infoframe_check() - check a HDMI DRM infoframe > + * @frame: HDMI DRM infoframe > + * > + * Validates that the infoframe is consistent. > + * Returns 0 on success or a negative error code on failure. > + */ Add empty line before "Returns ...", like in other places. _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx