Quoting Lucas De Marchi (2019-04-01 16:39:29) > On Mon, Mar 25, 2019 at 2:06 AM Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > I really like the use of small headers like this. We could do more on > other areas, too. One thing to consider is if we should settle on > intel_ or i915_ prefix. On display area we tend to use intel_. I classed this as part of the i915 GEM uapi facing code, so i915_gem. The principal caller of the wakeref pm is i915_gem_execbuffer, but it looked a bit lonely by itself so I added the suspend/runtime. However, this code is a bit mixed in terms of functionality between high level GEM ops and lower level interaction with HW, so I expect some refinement in future. The low level stuff will have intel_foo as it principally interacts with the HW (with i915_gem callers for the most part, and with i915_shiny callers if we house a new uapi). -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx