On Thu, 28 Mar 2019, Matt Roper <matthew.d.roper@xxxxxxxxx> wrote: > I agree with Jani's feedback and have a couple other comments inline below. Thanks Matt, good stuff here. One naming note below. > What does the "internal" in this name refer to? I think just something > like i9xx_get_gamma_config() would be sufficient > > Actually the term "gamma_config" on these functions makes me think we're > going to be reading out the gamma mode register as well, although that's > actually done in foo_get_pipe_config(). Maybe just calling this > something like "i9xx_get_gamma_lut()" or "i9xx_readout_gamma_lut()" > would be more clear? I'd like to retain "get" and "config" in the names, just to mentally map to what's going on. Having "gamma lut" in there is good too to distinguish from *_get_pipe_config(). BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
