Quoting Daniele Ceraolo Spurio (2019-03-28 17:45:32) > edram is not part of uncore and there is no requirement for the > detection to be done before we initialize the uncore functions. The > first check on HAS_EDRAM is in the ggtt_init path, so move it to > i915_driver_init_hw, where other dram-related detection happens. > > While at it, save the size in MB instead of the capabilities because the > size is the only thing we look at outside of the init function. > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> I'm devoid of good suggestions as to where better to place it. Certainly we don't want it in i915_drv.c, maybe intel_cache_topology.c. Anyway, that doesn't detract from the merits of this patch, Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
