== Series Details == Series: series starting with [CI,1/9] drm/i915: rename raw reg access functions URL : https://patchwork.freedesktop.org/series/58604/ State : warning == Summary == $ dim checkpatch origin/drm-tip 518022b1d8c7 drm/i915: rename raw reg access functions -:302: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #302: FILE: drivers/gpu/drm/i915/intel_uncore.h:232: +} +__raw_read(8, b) total: 0 errors, 0 warnings, 1 checks, 264 lines checked 9cb0c26b3438 drm/i915: add HAS_FORCEWAKE flag to uncore 578537728540 drm/i915: add uncore flags for unclaimed mmio db6d1bf4fef7 drm/i915: take a ref to the rpm in the uncore structure 3165d80fee26 drm/i915: switch uncore mmio funcs to use intel_uncore -:46: WARNING:LONG_LINE: line over 100 characters #46: FILE: drivers/gpu/drm/i915/i915_drv.h:3488: +#define I915_WRITE16_NOTRACE(reg__, val__) __I915_REG_OP(write16_notrace, dev_priv, (reg__), (val__)) -:231: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #231: FILE: drivers/gpu/drm/i915/intel_uncore.h:278: +#define __uncore_read(name__, x__, s__, trace__) \ +static inline u##x__ intel_uncore_##name__(struct intel_uncore *uncore, \ + i915_reg_t reg) \ +{ \ + return uncore->funcs.mmio_read##s__(uncore, reg, (trace__)); \ +} -:277: WARNING:LINE_SPACING: Missing a blank line after declarations #277: FILE: drivers/gpu/drm/i915/intel_uncore.h:324: + u32 upper, lower, old_upper, loop = 0; + upper = intel_uncore_read(uncore, upper_reg); total: 1 errors, 2 warnings, 0 checks, 295 lines checked 02c209860d4d drm/i915: switch intel_uncore_forcewake_for_reg to intel_uncore 09af615477d2 drm/i915: intel_wait_for_register_fw to uncore 003222962ccd drm/i915: switch intel_wait_for_register to uncore bc3211904f72 drm/i915: take a reference to uncore in the engine and use it -:421: WARNING:LONG_LINE: line over 100 characters #421: FILE: drivers/gpu/drm/i915/intel_engine_cs.c:1345: + ENGINE_READ(engine, RING_CTL) & (RING_WAIT | RING_WAIT_SEMAPHORE) ? " [waiting]" : ""); -:1042: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects? #1042: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:48: +#define __ENGINE_READ_OP(op__, engine__, reg__) \ + __ENGINE_REG_OP(op__, (engine__), reg__((engine__)->mmio_base)) -:1054: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects? #1054: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:56: +#define ENGINE_READ64(engine__, lower_reg__, upper_reg__) \ + __ENGINE_REG_OP(read64_2x32, (engine__), \ + lower_reg__((engine__)->mmio_base), \ + upper_reg__((engine__)->mmio_base)) -:1061: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects? #1061: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:61: +#define ENGINE_READ_IDX(engine__, reg__, idx__) \ + __ENGINE_REG_OP(read, (engine__), reg__((engine__)->mmio_base, (idx__))) -:1066: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'engine__' - possible side-effects? #1066: FILE: drivers/gpu/drm/i915/intel_ringbuffer.h:64: +#define __ENGINE_WRITE_OP(op__, engine__, reg__, val__) \ + __ENGINE_REG_OP(op__, (engine__), reg__((engine__)->mmio_base), (val__)) total: 0 errors, 1 warnings, 4 checks, 967 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
