Re: [PATCH 1/9] drm/i915: rename raw reg access functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniele,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20190325]
[cannot apply to v5.1-rc2]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Daniele-Ceraolo-Spurio/more-uncore-rework/20190326-110805
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-x011-201912 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/i915/intel_guc.h:28:0,
                    from drivers/gpu/drm/i915/intel_guc.c:25:
   drivers/gpu/drm/i915/intel_uncore.h: In function '__raw_uncore_read64':
>> drivers/gpu/drm/i915/intel_uncore.h:223:9: error: implicit declaration of function 'readq'; did you mean 'readl'? [-Werror=implicit-function-declaration]
     return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
            ^
>> drivers/gpu/drm/i915/intel_uncore.h:235:1: note: in expansion of macro '__raw_read'
    __raw_read(64, q)
    ^~~~~~~~~~
   drivers/gpu/drm/i915/intel_uncore.h: In function '__raw_uncore_write64':
>> drivers/gpu/drm/i915/intel_uncore.h:230:2: error: implicit declaration of function 'writeq'; did you mean 'writel'? [-Werror=implicit-function-declaration]
     write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
     ^
>> drivers/gpu/drm/i915/intel_uncore.h:240:1: note: in expansion of macro '__raw_write'
    __raw_write(64, q)
    ^~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +223 drivers/gpu/drm/i915/intel_uncore.h

   217	
   218	/* register access functions */
   219	#define __raw_read(x__, s__) \
   220	static inline u##x__ __raw_uncore_read##x__(const struct intel_uncore *uncore, \
   221						    i915_reg_t reg) \
   222	{ \
 > 223		return read##s__(uncore->regs + i915_mmio_reg_offset(reg)); \
   224	}
   225	
   226	#define __raw_write(x__, s__) \
   227	static inline void __raw_uncore_write##x__(const struct intel_uncore *uncore, \
   228						   i915_reg_t reg, u##x__ val) \
   229	{ \
 > 230		write##s__(val, uncore->regs + i915_mmio_reg_offset(reg)); \
   231	}
   232	__raw_read(8, b)
   233	__raw_read(16, w)
   234	__raw_read(32, l)
 > 235	__raw_read(64, q)
   236	
   237	__raw_write(8, b)
   238	__raw_write(16, w)
   239	__raw_write(32, l)
 > 240	__raw_write(64, q)
   241	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux