On Sun, Mar 24, 2019 at 01:47:08PM +0000, Chris Wilson wrote: > Quoting Michał Winiarski (2019-03-22 16:20:37) > > static int gen8_gmch_probe(struct i915_ggtt *ggtt) > > @@ -3517,14 +3327,6 @@ void i915_gem_restore_gtt_mappings(struct drm_i915_private *dev_priv) > > i915_ggtt_invalidate(dev_priv); > > > > mutex_unlock(&ggtt->vm.mutex); > > - > > - if (INTEL_GEN(dev_priv) >= 8) { > > - struct intel_ppat *ppat = &dev_priv->ppat; > > - > > - bitmap_set(ppat->dirty, 0, ppat->max_entries); > > - dev_priv->ppat.update_hw(dev_priv); > > Missed on the first pass, do we need to keep the restore, i.e. call > setup_private_pat() again? Yeah, we do, fortunately CI caught it. Sending v2. -Michał > -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx