== Series Details == Series: series starting with [CI,1/4] drm/i915: Introduce the i915_user_extension_method (rev3) URL : https://patchwork.freedesktop.org/series/58402/ State : warning == Summary == $ dim checkpatch origin/drm-tip fd4168c2494d drm/i915: Introduce the i915_user_extension_method -:72: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #72: new file mode 100644 -:77: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #77: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1: +/* -:78: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #78: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:2: + * SPDX-License-Identifier: MIT -:144: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #144: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1: +/* -:145: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #145: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:2: + * SPDX-License-Identifier: MIT -:178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects? #178: FILE: drivers/gpu/drm/i915/i915_utils.h:114: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #178: FILE: drivers/gpu/drm/i915/i915_utils.h:114: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:178: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues #178: FILE: drivers/gpu/drm/i915/i915_utils.h:114: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'U' - possible side-effects? #198: FILE: drivers/gpu/drm/i915/i915_utils.h:134: +#define check_user_mbz(U) ({ \ + typeof(*(U)) mbz__; \ + get_user(mbz__, (U)) ? -EFAULT : mbz__ ? -EINVAL : 0; \ +}) total: 0 errors, 5 warnings, 4 checks, 153 lines checked aac9ec7d3dda drm/i915: Create/destroy VM (ppGTT) for use with contexts -:694: WARNING:LINE_SPACING: Missing a blank line after declarations #694: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:504: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:756: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #756: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:566: + ncontexts = dw = 0; -:830: WARNING:LINE_SPACING: Missing a blank line after declarations #830: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:633: + struct drm_i915_gem_object *obj = NULL; + IGT_TIMEOUT(end_time); -:902: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #902: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:688: + ncontexts = dw = 0; -:1057: WARNING:LONG_LINE: line over 100 characters #1057: FILE: include/uapi/drm/i915_drm.h:407: +#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control) -:1058: WARNING:LONG_LINE: line over 100 characters #1058: FILE: include/uapi/drm/i915_drm.h:408: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:1058: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1058: FILE: include/uapi/drm/i915_drm.h:408: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:1058: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1058: FILE: include/uapi/drm/i915_drm.h:408: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) total: 1 errors, 5 warnings, 2 checks, 998 lines checked b533ca0b0590 drm/i915: Extend CONTEXT_CREATE to set parameters upon construction -:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_drv.c:3081: + DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT, i915_gem_context_create_ioctl, DRM_RENDER_ALLOW), -:541: WARNING:LONG_LINE: line over 100 characters #541: FILE: include/uapi/drm/i915_drm.h:397: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:541: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #541: FILE: include/uapi/drm/i915_drm.h:397: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:541: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #541: FILE: include/uapi/drm/i915_drm.h:397: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) total: 1 errors, 3 warnings, 0 checks, 701 lines checked 9ae6733cd12f drm/i915: Allow contexts to share a single timeline across all engines _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
