On Thu, 21 Mar 2019, Lucas De Marchi <lucas.demarchi@xxxxxxxxx> wrote: > Instead of re-reading the registers we just read on the hw state > readout, use the values saved on intel_shared_dpll. Besides not doing > the MMIO, this helps on sharing code since we don't have to > differentiate e.g. ICL and CNL because they have different registers for > the same thing. > > I'm a little hesitant wrt DSI. It seems we have completly different > implementations for ICL and gen <= 11. That's obviously a typo, ICL being gen 11 and introducing the new DSI hardware and requiring a completely different implementation. > BXT has another hook so is not affected, but I'm not sure if we have > any other gens with DSI that share the skl hooks. VLV/CHV/BXT/GLK all have their own DSI PLL stuff. ICL or gen 11 is the divider. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
