Op 21-03-2019 om 11:29 schreef Ville Syrjälä: > On Thu, Mar 21, 2019 at 10:15:45AM +0100, Maarten Lankhorst wrote: >> Now that we can rotate 64 bpp formats, we need to add the rotation case. >> This wasn't caught by CI or me, because the rotated formats were skipping >> because the rotated watermarks exceeded the allocation limits. >> >> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx> >> --- >> drivers/gpu/drm/i915/intel_pm.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c >> index fcd3baff8b65..5977dca2c55d 100644 >> --- a/drivers/gpu/drm/i915/intel_pm.c >> +++ b/drivers/gpu/drm/i915/intel_pm.c >> @@ -4689,6 +4689,9 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state, >> case 4: >> wp->y_min_scanlines = 4; >> break; >> + case 8: >> + wp->y_min_scanlines = 2; >> + break; > Spec says n/a here. And indeed the table says 90/270 is not supported > with any 64bpp format. Indeed. Looks like rotation is not allowed for Y41x/Y21x, will drop this patch and tighten restrictions instead. :) _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
