== Series Details == Series: series starting with [CI,1/7] drm/i915: use intel_uncore in fw get/put internal paths URL : https://patchwork.freedesktop.org/series/58295/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4cfa03897df drm/i915: use intel_uncore in fw get/put internal paths -:602: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'tmp__' - possible side-effects? #602: FILE: drivers/gpu/drm/i915/intel_uncore.h:131: +#define for_each_fw_domain_masked(domain__, mask__, uncore__, tmp__) \ for (tmp__ = (mask__); \ + tmp__ ? (domain__ = &(uncore__)->fw_domain[__mask_next_bit(tmp__)]), 1 : 0;) -:609: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore__' - possible side-effects? #609: FILE: drivers/gpu/drm/i915/intel_uncore.h:135: +#define for_each_fw_domain(domain__, uncore__, tmp__) \ + for_each_fw_domain_masked(domain__, (uncore__)->fw_domains, uncore__, tmp__) total: 0 errors, 0 warnings, 2 checks, 598 lines checked 4a41e6aaf6e2 drm/i915: use intel_uncore for all forcewake get/put -:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #61: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:992: + intel_uncore_forcewake_get(&gvt->dev_priv->uncore, FORCEWAKE_ALL); -:70: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #70: FILE: drivers/gpu/drm/i915/gvt/scheduler.c:1014: + intel_uncore_forcewake_put(&gvt->dev_priv->uncore, FORCEWAKE_ALL); total: 0 errors, 0 warnings, 2 checks, 797 lines checked 324c86364504 drm/i915: make more uncore function work on intel_uncore -:193: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #193: FILE: drivers/gpu/drm/i915/intel_uncore.c:1308: +#define ASSIGN_WRITE_MMIO_VFUNCS(uncore, x) \ do { \ + (uncore)->funcs.mmio_writeb = x##_write8; \ + (uncore)->funcs.mmio_writew = x##_write16; \ + (uncore)->funcs.mmio_writel = x##_write32; \ } while (0) -:204: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #204: FILE: drivers/gpu/drm/i915/intel_uncore.c:1315: +#define ASSIGN_READ_MMIO_VFUNCS(uncore, x) \ do { \ + (uncore)->funcs.mmio_readb = x##_read8; \ + (uncore)->funcs.mmio_readw = x##_read16; \ + (uncore)->funcs.mmio_readl = x##_read32; \ + (uncore)->funcs.mmio_readq = x##_read64; \ } while (0) -:416: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'uncore' - possible side-effects? #416: FILE: drivers/gpu/drm/i915/intel_uncore.c:1499: +#define ASSIGN_FW_DOMAINS_TABLE(uncore, d) \ { \ + (uncore)->fw_domains_table = \ (struct intel_forcewake_range *)(d); \ + (uncore)->fw_domains_table_entries = ARRAY_SIZE((d)); \ } -:416: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects? #416: FILE: drivers/gpu/drm/i915/intel_uncore.c:1499: +#define ASSIGN_FW_DOMAINS_TABLE(uncore, d) \ { \ + (uncore)->fw_domains_table = \ (struct intel_forcewake_range *)(d); \ + (uncore)->fw_domains_table_entries = ARRAY_SIZE((d)); \ } total: 0 errors, 0 warnings, 4 checks, 583 lines checked 44ccf0c60285 drm/i915: make find_fw_domain work on intel_uncore d1738ce19086 drm/i915: reduce the dev_priv->uncore dance in uncore.c -:58: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #58: FILE: drivers/gpu/drm/i915/intel_uncore.c:885: +#define __fwtable_reg_read_fw_domains(uncore, offset) \ ({ \ enum forcewake_domains __fwd = 0; \ if (NEEDS_FORCE_WAKE((offset))) \ + __fwd = find_fw_domain(uncore, offset); \ __fwd; \ }) -:68: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #68: FILE: drivers/gpu/drm/i915/intel_uncore.c:893: +#define __gen11_fwtable_reg_read_fw_domains(uncore, offset) \ ({ \ enum forcewake_domains __fwd = 0; \ if (GEN11_NEEDS_FORCE_WAKE((offset))) \ + __fwd = find_fw_domain(uncore, offset); \ __fwd; \ }) -:82: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #82: FILE: drivers/gpu/drm/i915/intel_uncore.c:949: +#define __gen8_reg_write_fw_domains(uncore, offset) \ ({ \ enum forcewake_domains __fwd; \ if (NEEDS_FORCE_WAKE(offset) && !is_gen8_shadowed(offset)) \ -:91: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #91: FILE: drivers/gpu/drm/i915/intel_uncore.c:979: +#define __fwtable_reg_write_fw_domains(uncore, offset) \ ({ \ enum forcewake_domains __fwd = 0; \ if (NEEDS_FORCE_WAKE((offset)) && !is_gen8_shadowed(offset)) \ + __fwd = find_fw_domain(uncore, offset); \ __fwd; \ }) -:101: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'offset' - possible side-effects? #101: FILE: drivers/gpu/drm/i915/intel_uncore.c:987: +#define __gen11_fwtable_reg_write_fw_domains(uncore, offset) \ ({ \ enum forcewake_domains __fwd = 0; \ if (GEN11_NEEDS_FORCE_WAKE((offset)) && !is_gen11_shadowed(offset)) \ + __fwd = find_fw_domain(uncore, offset); \ __fwd; \ }) total: 0 errors, 0 warnings, 5 checks, 252 lines checked a8cd9aea48b2 drm/i915: move regs pointer inside the uncore structure -:305: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!uncore->regs" #305: FILE: drivers/gpu/drm/i915/intel_uncore.c:1562: + if (uncore->regs == NULL) { -:322: CHECK:LINE_SPACING: Please don't use multiple blank lines #322: FILE: drivers/gpu/drm/i915/intel_uncore.c:1579: + + total: 0 errors, 0 warnings, 2 checks, 315 lines checked b56309235f84 drm/i915: make raw access function work on uncore -:95: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #95: FILE: drivers/gpu/drm/i915/intel_uncore.c:34: +#define __raw_posting_read(uncore__, reg__) (void)__raw_i915_read32((uncore__), (reg__)) -:161: ERROR:ASSIGN_IN_IF: do not use assignment in if condition #161: FILE: drivers/gpu/drm/i915/intel_uncore.c:326: + if (wait_for_atomic((n = fifo_free_entries(uncore)) > total: 2 errors, 0 warnings, 0 checks, 337 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
