Quoting Daniele Ceraolo Spurio (2019-03-19 18:35:43) > The full read/write ops can now work on the intel_uncore struct > > Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@xxxxxxxxx> > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_drv.h | 25 ++++++++++--------- > drivers/gpu/drm/i915/intel_uncore.c | 26 +++++++++----------- > drivers/gpu/drm/i915/intel_uncore.h | 14 +++++------ > drivers/gpu/drm/i915/selftests/mock_uncore.c | 4 +-- > 4 files changed, 34 insertions(+), 35 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index fb77420370e4..9fe66b62787c 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -3440,18 +3440,21 @@ static inline u64 intel_rc6_residency_us(struct drm_i915_private *dev_priv, > return DIV_ROUND_UP_ULL(intel_rc6_residency_ns(dev_priv, reg), 1000); > } > > -#define I915_READ8(reg) dev_priv->uncore.funcs.mmio_readb(dev_priv, (reg), true) > -#define I915_WRITE8(reg, val) dev_priv->uncore.funcs.mmio_writeb(dev_priv, (reg), (val), true) > +#define __I915_REG_OP(op, reg, ...) \ > + dev_priv->uncore.funcs.mmio_##op(&dev_priv->uncore, (reg), ##__VA_ARGS__) No uncore? No inlines for intel_uncore_read8..32? While you are here, give us the tools to transition away from the implicit parameter of I915_READ() into something sustainable. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
