On Tue, Mar 19, 2019 at 08:36:17PM +0200, Imre Deak wrote: > We copied the original state into the atomic state already earlier in > the function, so no need to do it a second time. > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > Signed-off-by: Imre Deak <imre.deak@xxxxxxxxx> Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> The rest looks ok to me as well. > --- > drivers/gpu/drm/i915/intel_display.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index 9c4ad124302c..f7b44773e1e7 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -13031,8 +13031,6 @@ static int intel_modeset_checks(struct drm_atomic_state *state) > DRM_DEBUG_KMS("New voltage level calculated to be logical %u, actual %u\n", > intel_state->cdclk.logical.voltage_level, > intel_state->cdclk.actual.voltage_level); > - } else { > - to_intel_atomic_state(state)->cdclk.logical = dev_priv->cdclk.logical; > } > > intel_modeset_clear_plls(state); > -- > 2.13.2 -- Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx