On Mon, 18 Mar 2019, Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > On Mon, Mar 18, 2019 at 09:45:16PM +0100, Michal Wajdeczko wrote: >> > Make things look a bit nicer by passing dev_priv to >> >> In other places we are changing naming from dev_priv to i915. >> Can we do the same here ? > > The display code uses dev_priv quite consistently,. We could > go for i915 I suppose but I'd prefer a mass conversion rather > than the death by a thousand cuts approach. The display > code is already messy enough when it comes to naming local > variables. We could use i915 in display code as a convention for code that does not do register access. ;) BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx