Re: [PATCH 04/18] drm/i915: Separate GEM context construction and registration to userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-03-19 13:41:37)
> 
> On 19/03/2019 11:57, Chris Wilson wrote:
> > In later patches, it became apparent that userspace can see a partially
> > constructed GEM context and begin using it before it was ready, to much
> > hilarity. Close this window of opportunity by lifting the registration of
> > the context with userspace (the insertion of the context into the filp's
> > idr) to the very end of the CONTEXT_CREATE ioctl.
> 
> Thanks, persistent absence of change logs really helps me.

And nothing of significance changed, that was the point.

The debug name of the context was changed to avoid having the
self-referential problem of how to get the ctx-id but set the ctx->name
prior to inserting the id into the context; which could have been pushed
under the idr_lock, but I choose to take the course of removing the
extra user_handle as evidenced by the next few patches.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux