== Series Details == Series: series starting with [01/18] drm/i915/selftests: Provide stub reset functions (rev2) URL : https://patchwork.freedesktop.org/series/58179/ State : warning == Summary == $ dim checkpatch origin/drm-tip 58fb48773f00 drm/i915/selftests: Provide stub reset functions 8ad2cbde4c11 drm/i915: Flush pages on acquisition f4793bc16874 drm/i915: Move intel_engine_mask_t around for use by i915_request_types.h -:652: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #652: new file mode 100644 -:657: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #657: FILE: drivers/gpu/drm/i915/i915_scheduler_types.h:1: +/* -:658: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #658: FILE: drivers/gpu/drm/i915/i915_scheduler_types.h:2: + * SPDX-License-Identifier: MIT -:913: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #913: FILE: drivers/gpu/drm/i915/test_i915_scheduler_types_standalone.c:1: +/* -:914: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #914: FILE: drivers/gpu/drm/i915/test_i915_scheduler_types_standalone.c:2: + * SPDX-License-Identifier: MIT total: 0 errors, 5 warnings, 0 checks, 730 lines checked 1b198564eec8 drm/i915: Separate GEM context construction and registration to userspace e56b4575afb8 drm/i915: Introduce a mutex for file_priv->context_idr 9a2c41a4a900 drm/i915: Stop storing ctx->user_handle ad0bb57b1067 drm/i915: Stop storing the context name as the timeline name 49a44c5b96d9 drm/i915: Introduce the i915_user_extension_method -:72: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #72: new file mode 100644 -:77: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #77: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1: +/* -:78: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #78: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:2: + * SPDX-License-Identifier: MIT -:144: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #144: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1: +/* -:145: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead #145: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:2: + * SPDX-License-Identifier: MIT -:178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects? #178: FILE: drivers/gpu/drm/i915/i915_utils.h:114: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:178: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #178: FILE: drivers/gpu/drm/i915/i915_utils.h:114: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:178: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues #178: FILE: drivers/gpu/drm/i915/i915_utils.h:114: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:198: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'U' - possible side-effects? #198: FILE: drivers/gpu/drm/i915/i915_utils.h:134: +#define check_user_mbz(U) ({ \ + typeof(*(U)) mbz__; \ + get_user(mbz__, (U)) ? -EFAULT : mbz__ ? -EINVAL : 0; \ +}) total: 0 errors, 5 warnings, 4 checks, 153 lines checked da478a2b2e84 drm/i915: Create/destroy VM (ppGTT) for use with contexts -:693: WARNING:LINE_SPACING: Missing a blank line after declarations #693: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:504: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:755: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #755: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:566: + ncontexts = dw = 0; -:829: WARNING:LINE_SPACING: Missing a blank line after declarations #829: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:633: + struct drm_i915_gem_object *obj = NULL; + IGT_TIMEOUT(end_time); -:901: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #901: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:688: + ncontexts = dw = 0; -:1056: WARNING:LONG_LINE: line over 100 characters #1056: FILE: include/uapi/drm/i915_drm.h:407: +#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control) -:1057: WARNING:LONG_LINE: line over 100 characters #1057: FILE: include/uapi/drm/i915_drm.h:408: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:1057: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1057: FILE: include/uapi/drm/i915_drm.h:408: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:1057: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1057: FILE: include/uapi/drm/i915_drm.h:408: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) total: 1 errors, 5 warnings, 2 checks, 998 lines checked ab79a55630ef drm/i915: Extend CONTEXT_CREATE to set parameters upon construction -:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_drv.c:3113: + DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT, i915_gem_context_create_ioctl, DRM_RENDER_ALLOW), -:541: WARNING:LONG_LINE: line over 100 characters #541: FILE: include/uapi/drm/i915_drm.h:397: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:541: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #541: FILE: include/uapi/drm/i915_drm.h:397: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:541: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #541: FILE: include/uapi/drm/i915_drm.h:397: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) total: 1 errors, 3 warnings, 0 checks, 701 lines checked 32f18f1740ab drm/i915: Allow contexts to share a single timeline across all engines 281831a71ef7 drm/i915: Allow userspace to clone contexts on creation -:132: ERROR:BRACKET_SPACE: space prohibited before open square bracket '[' #132: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1610: +#define MAP(x, y) [ilog2(I915_CONTEXT_CLONE_##x)] = y total: 1 errors, 0 warnings, 0 checks, 182 lines checked a9295a3f81ed drm/i915: Allow a context to define its set of engines -:482: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'p' - possible side-effects? #482: FILE: drivers/gpu/drm/i915/i915_utils.h:107: +#define check_struct_size(p, member, n, sz) \ + likely(__check_struct_size(sizeof(*(p)), \ + sizeof(*(p)->member) + __must_be_array((p)->member), \ + n, sz)) -:482: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #482: FILE: drivers/gpu/drm/i915/i915_utils.h:107: +#define check_struct_size(p, member, n, sz) \ + likely(__check_struct_size(sizeof(*(p)), \ + sizeof(*(p)->member) + __must_be_array((p)->member), \ + n, sz)) -:482: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues #482: FILE: drivers/gpu/drm/i915/i915_utils.h:107: +#define check_struct_size(p, member, n, sz) \ + likely(__check_struct_size(sizeof(*(p)), \ + sizeof(*(p)->member) + __must_be_array((p)->member), \ + n, sz)) total: 0 errors, 0 warnings, 3 checks, 490 lines checked d64f177b1ad9 drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[] 8df62463e41e drm/i915: Load balancing across a virtual engine -:955: WARNING:LINE_SPACING: Missing a blank line after declarations #955: FILE: drivers/gpu/drm/i915/intel_lrc.c:3387: + struct intel_engine_cs *actual = ve->siblings[0]; + intel_context_put(&ve->context); total: 0 errors, 1 warnings, 0 checks, 1156 lines checked 9a7b936e9c73 drm/i915: Extend execution fence to support a callback c584d1697f6f drm/i915/execlists: Virtual engine bonding d1d3ac6c6916 drm/i915: Allow specification of parallel execbuf _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
