== Series Details == Series: Add Plane Color Properties (rev6) URL : https://patchwork.freedesktop.org/series/30875/ State : warning == Summary == $ dim checkpatch origin/drm-tip ac8ffabdea94 drm: Add Enhanced Gamma LUT precision structure cb4da76aa060 drm: Add Plane Degamma properties -:180: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #180: FILE: drivers/gpu/drm/drm_atomic_uapi.c:577: + ret = drm_atomic_replace_property_blob_from_id(dev, + &state->degamma_lut, total: 0 errors, 0 warnings, 1 checks, 253 lines checked 6d1310f593e8 drm: Add Plane CTM property -:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #69: FILE: drivers/gpu/drm/drm_atomic_uapi.c:584: + ret = drm_atomic_replace_property_blob_from_id(dev, + &state->ctm, total: 0 errors, 0 warnings, 1 checks, 97 lines checked 874066e51de7 drm: Add Plane Gamma properties -:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #72: FILE: drivers/gpu/drm/drm_atomic_uapi.c:592: + ret = drm_atomic_replace_property_blob_from_id(dev, + &state->gamma_lut, total: 0 errors, 0 warnings, 1 checks, 116 lines checked aa2c66edd9cb drm: Define helper function for plane color enabling a469bd374d08 drm/i915: Enable plane color features -:62: WARNING:LONG_LINE: line over 100 characters #62: FILE: drivers/gpu/drm/i915/intel_color.c:882: + INTEL_INFO(dev_priv)->plane_color.plane_degamma_lut_size, total: 0 errors, 1 warnings, 0 checks, 71 lines checked 3b9c169dbec3 drm/i915: Implement Plane Gamma for Bdw and Gen9 platforms -:62: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #62: FILE: drivers/gpu/drm/i915/i915_reg.h:10170: +#define PLANE_GAMC(pipe, plane, i) \ + _MMIO_PLANE_GAMC(plane, i, _PLANE_GAMC_1(pipe), _PLANE_GAMC_2(pipe)) -:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #73: FILE: drivers/gpu/drm/i915/i915_reg.h:10181: +#define PLANE_GAMC16(pipe, plane, i) _MMIO_PLANE_GAMC16(plane, i, \ + _PLANE_GAMC16_1(pipe), _PLANE_GAMC16_2(pipe)) total: 0 errors, 0 warnings, 2 checks, 137 lines checked fe57d6db3259 drm/i915: Load plane color luts from atomic flip eba9f1c9b828 drm/i915: Add plane color capabilities 415f57b6a941 drm/i915/icl: Add ICL Plane Degamma Register definition -:24: WARNING:LONG_LINE: line over 100 characters #24: FILE: drivers/gpu/drm/i915/i915_reg.h:10190: +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1_B) -:25: WARNING:LONG_LINE: line over 100 characters #25: FILE: drivers/gpu/drm/i915/i915_reg.h:10191: +#define _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_A, _PLANE_PRE_CSC_GAMC_INDEX_ENH_2_B) -:27: WARNING:LONG_LINE: line over 100 characters #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10193: +#define PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\ -:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10193: +#define PLANE_PRE_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_ENH_1(pipe),\ + _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)) -:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_reg.h:10194: + _PLANE_PRE_CSC_GAMC_INDEX_ENH_2(pipe)) -:34: WARNING:LONG_LINE: line over 100 characters #34: FILE: drivers/gpu/drm/i915/i915_reg.h:10200: +#define _PLANE_PRE_CSC_GAMC_INDEX_4(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_4_A, _PLANE_PRE_CSC_GAMC_INDEX_4_B) -:35: WARNING:LONG_LINE: line over 100 characters #35: FILE: drivers/gpu/drm/i915/i915_reg.h:10201: +#define _PLANE_PRE_CSC_GAMC_INDEX_5(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_INDEX_5_A, _PLANE_PRE_CSC_GAMC_INDEX_5_B) -:37: WARNING:LONG_LINE: line over 100 characters #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10203: +#define PLANE_PRE_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\ -:37: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10203: +#define PLANE_PRE_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_INDEX_4(pipe),\ + _PLANE_PRE_CSC_GAMC_INDEX_5(pipe)) -:38: WARNING:LONG_LINE: line over 100 characters #38: FILE: drivers/gpu/drm/i915/i915_reg.h:10204: + _PLANE_PRE_CSC_GAMC_INDEX_5(pipe)) -:44: WARNING:LONG_LINE: line over 100 characters #44: FILE: drivers/gpu/drm/i915/i915_reg.h:10210: +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_1_B) -:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10211: +#define _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_A, _PLANE_PRE_CSC_GAMC_DATA_ENH_2_B) -:47: WARNING:LONG_LINE: line over 100 characters #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10213: +#define PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\ -:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10213: +#define PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_ENH_1(pipe),\ + _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)) -:48: WARNING:LONG_LINE: line over 100 characters #48: FILE: drivers/gpu/drm/i915/i915_reg.h:10214: + _PLANE_PRE_CSC_GAMC_DATA_ENH_2(pipe)) -:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/i915_reg.h:10220: +#define _PLANE_PRE_CSC_GAMC_DATA_4(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_4_A, _PLANE_PRE_CSC_GAMC_DATA_4_B) -:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/i915_reg.h:10221: +#define _PLANE_PRE_CSC_GAMC_DATA_5(pipe) _PIPE(pipe, _PLANE_PRE_CSC_GAMC_DATA_5_A, _PLANE_PRE_CSC_GAMC_DATA_5_B) -:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10223: +#define PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\ -:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10223: +#define PLANE_PRE_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_PRE_CSC_GAMC_DATA_4(pipe),\ + _PLANE_PRE_CSC_GAMC_DATA_5(pipe)) -:58: WARNING:LONG_LINE: line over 100 characters #58: FILE: drivers/gpu/drm/i915/i915_reg.h:10224: + _PLANE_PRE_CSC_GAMC_DATA_5(pipe)) total: 0 errors, 16 warnings, 4 checks, 48 lines checked 6db8c958bceb drm/i915/icl: Enable Plane Degamma -:51: WARNING:LINE_SPACING: Missing a blank line after declarations #51: FILE: drivers/gpu/drm/i915/intel_color.c:651: + u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1); + I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i), v); total: 0 errors, 1 warnings, 0 checks, 98 lines checked dc49d1b1bc11 drm/i915/icl: Add Plane Gamma Register Definitions -:24: WARNING:LONG_LINE: line over 100 characters #24: FILE: drivers/gpu/drm/i915/i915_reg.h:10230: +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_A, _PLANE_POST_CSC_GAMC_INDEX_ENH_1_B) -:25: WARNING:LONG_LINE: line over 100 characters #25: FILE: drivers/gpu/drm/i915/i915_reg.h:10231: +#define _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_A, _PLANE_POST_CSC_GAMC_INDEX_ENH_2_B) -:27: WARNING:LONG_LINE: line over 100 characters #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10233: +#define PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe),\ -:27: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #27: FILE: drivers/gpu/drm/i915/i915_reg.h:10233: +#define PLANE_POST_CSC_GAMC_INDEX_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_ENH_1(pipe),\ + _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe)) -:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_reg.h:10234: + _PLANE_POST_CSC_GAMC_INDEX_ENH_2(pipe)) -:34: WARNING:LONG_LINE: line over 100 characters #34: FILE: drivers/gpu/drm/i915/i915_reg.h:10240: +#define _PLANE_POST_CSC_GAMC_INDEX_4(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_INDEX_4_A, _PLANE_POST_CSC_GAMC_INDEX_4_B) -:35: WARNING:LONG_LINE: line over 100 characters #35: FILE: drivers/gpu/drm/i915/i915_reg.h:10241: +#define _PLANE_POST_CSC_GAMC_INDEX_5(pipe) _PIPE(pipe, _PLANE_POSt_CSC_GAMC_INDEX_5_A, _PLANE_POST_CSC_GAMC_INDEX_5_B) -:35: CHECK:CAMELCASE: Avoid CamelCase: <_PLANE_POSt_CSC_GAMC_INDEX_5_A> #35: FILE: drivers/gpu/drm/i915/i915_reg.h:10241: +#define _PLANE_POST_CSC_GAMC_INDEX_5(pipe) _PIPE(pipe, _PLANE_POSt_CSC_GAMC_INDEX_5_A, _PLANE_POST_CSC_GAMC_INDEX_5_B) -:37: WARNING:LONG_LINE: line over 100 characters #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10243: +#define PLANE_POST_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_4(pipe),\ -:37: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #37: FILE: drivers/gpu/drm/i915/i915_reg.h:10243: +#define PLANE_POST_CSC_GAMC_INDEX(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_INDEX_4(pipe),\ + _PLANE_POSt_CSC_GAMC_INDEX_5(pipe)) -:38: WARNING:LONG_LINE: line over 100 characters #38: FILE: drivers/gpu/drm/i915/i915_reg.h:10244: + _PLANE_POSt_CSC_GAMC_INDEX_5(pipe)) -:38: CHECK:CAMELCASE: Avoid CamelCase: <_PLANE_POSt_CSC_GAMC_INDEX_5> #38: FILE: drivers/gpu/drm/i915/i915_reg.h:10244: + _PLANE_POSt_CSC_GAMC_INDEX_5(pipe)) -:44: WARNING:LONG_LINE: line over 100 characters #44: FILE: drivers/gpu/drm/i915/i915_reg.h:10250: +#define _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_1_A, _PLANE_POST_CSC_GAMC_DATA_ENH_1_B) -:45: WARNING:LONG_LINE: line over 100 characters #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10251: +#define _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_ENH_2_A, _PLANE_POST_CSC_GAMC_DATA_ENH_2_B) -:47: WARNING:LONG_LINE: line over 100 characters #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10253: +#define PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe),\ -:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #47: FILE: drivers/gpu/drm/i915/i915_reg.h:10253: +#define PLANE_POST_CSC_GAMC_DATA_ENH(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_ENH_1(pipe),\ + _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe)) -:48: WARNING:LONG_LINE: line over 100 characters #48: FILE: drivers/gpu/drm/i915/i915_reg.h:10254: + _PLANE_POST_CSC_GAMC_DATA_ENH_2(pipe)) -:54: WARNING:LONG_LINE: line over 100 characters #54: FILE: drivers/gpu/drm/i915/i915_reg.h:10260: +#define _PLANE_POST_CSC_GAMC_DATA_4(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_4_A, _PLANE_POST_CSC_GAMC_DATA_4_B) -:55: WARNING:LONG_LINE: line over 100 characters #55: FILE: drivers/gpu/drm/i915/i915_reg.h:10261: +#define _PLANE_POST_CSC_GAMC_DATA_5(pipe) _PIPE(pipe, _PLANE_POST_CSC_GAMC_DATA_5_A, _PLANE_POST_CSC_GAMC_DATA_5_B) -:57: WARNING:LONG_LINE: line over 100 characters #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10263: +#define PLANE_POST_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_4(pipe),\ -:57: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #57: FILE: drivers/gpu/drm/i915/i915_reg.h:10263: +#define PLANE_POST_CSC_GAMC_DATA(pipe, plane, i) _MMIO_PLANE_GAMC(plane, i, _PLANE_POST_CSC_GAMC_DATA_4(pipe),\ + _PLANE_POST_CSC_GAMC_DATA_5(pipe)) -:58: WARNING:LONG_LINE: line over 100 characters #58: FILE: drivers/gpu/drm/i915/i915_reg.h:10264: + _PLANE_POST_CSC_GAMC_DATA_5(pipe)) total: 0 errors, 16 warnings, 6 checks, 48 lines checked d2c749cba6ef drm/i915/icl: Implement Plane Gamma -:49: WARNING:LINE_SPACING: Missing a blank line after declarations #49: FILE: drivers/gpu/drm/i915/intel_color.c:726: + u32 v = (i * ((1 << 24) - 1)) / (lut_size - 1); + I915_WRITE(PLANE_PRE_CSC_GAMC_DATA_ENH(pipe, plane, i), v); total: 0 errors, 1 warnings, 0 checks, 85 lines checked d4c386908867 drm/i915: Enable Plane Gamma/Degamma 723fb9c0bb23 drm/i915: Define Plane CSC Registers -:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/i915_reg.h:10279: +#define PLANE_CSC_COEFF(pipe, plane, index) _MMIO_PLANE(plane, \ + _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \ + _PLANE_CSC_RY_GY_2(pipe) + (index) * 4) -:31: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #31: FILE: drivers/gpu/drm/i915/i915_reg.h:10279: +#define PLANE_CSC_COEFF(pipe, plane, index) _MMIO_PLANE(plane, \ + _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \ + _PLANE_CSC_RY_GY_2(pipe) + (index) * 4) -:32: WARNING:LONG_LINE: line over 100 characters #32: FILE: drivers/gpu/drm/i915/i915_reg.h:10280: + _PLANE_CSC_RY_GY_1(pipe) + (index) * 4, \ -:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10293: +#define PLANE_CSC_PREOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \ + (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \ + (index) * 4) -:45: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #45: FILE: drivers/gpu/drm/i915/i915_reg.h:10293: +#define PLANE_CSC_PREOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_PREOFF_HI_1(pipe) + \ + (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \ + (index) * 4) -:46: WARNING:LONG_LINE: line over 100 characters #46: FILE: drivers/gpu/drm/i915/i915_reg.h:10294: + (index) * 4, _PLANE_CSC_PREOFF_HI_2(pipe) + \ -:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'pipe' - possible side-effects? #59: FILE: drivers/gpu/drm/i915/i915_reg.h:10307: +#define PLANE_CSC_POSTOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \ + (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \ + (index) * 4) -:59: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects? #59: FILE: drivers/gpu/drm/i915/i915_reg.h:10307: +#define PLANE_CSC_POSTOFF(pipe, plane, index) _MMIO_PLANE(plane, _PLANE_CSC_POSTOFF_HI_1(pipe) + \ + (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \ + (index) * 4) -:60: WARNING:LONG_LINE: line over 100 characters #60: FILE: drivers/gpu/drm/i915/i915_reg.h:10308: + (index) * 4, _PLANE_CSC_POSTOFF_HI_2(pipe) + \ total: 0 errors, 3 warnings, 6 checks, 50 lines checked 0193721b12d3 drm/i915: Enable Plane CSC _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
