Re: [PATCH 2/3] drm/i915: Remove redundant device id from IS_IRONLAKE_M macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-03-18 09:52:57)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

> Check can use the already defined and separate device info for this

That doesn't read very well:

IS_IRONLAKE_M can use the already defined intel_device_info.is_mobile
for this platform, so remove the instance of Ironlake's mobile device id
from the header file and replace it with an IS_MOBILE check.

> platform in conjunction with the IS_MOBILE check. So remove this instance
> of device id from the header file.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> Suggested-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux