Re: [PATCH 3/3] drm/i915: Remove HAS_FULL_PPGTT and device_info.ppgtt enum (v3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Bob Paauwe (2019-03-14 20:09:57)
> Chris,
> 
> Any thoughts on how I can best address your comment on this patch?

I do not see the value in this patch as it is.

Don't remove intel_device_info.ppgtt; rename it to ppgtt_mode. Put
ppgtt_size alongside. Ie keep using intel_device_info.ppgtt_mode to
differentiate between none/aliasing/full for initialisation, then the
normal pointer dance from i915_gem_context to determine which is active.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux