Re: [PATCH] drm/i915/display: Reduce log level for DP command signal timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'll add the Signed Off by line when I re-submit the patch after a
review.

Thanks,
Vanshi

On Thu, Mar 14, 2019 at 10:58:49AM -0700, Vanshidhar Konda wrote:
The log level for timeout after waiting for a signal on the  DP aux
channel control register is set to DRM_ERROR. But this is timeout not a
fatal error as the driver is expected to retry the command. Failure
after all retries is already captured as an error. Hence, reducing the
log for a timeout to warning instead of error.
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 47857f96c3b1..f51e8b2ccb17 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -1069,7 +1069,7 @@ intel_dp_aux_wait_done(struct intel_dp *intel_dp)
	trace_i915_reg_rw(false, ch_ctl, status, sizeof(status), true);

	if (!done)
-		DRM_ERROR("dp aux hw did not signal timeout!\n");
+		DRM_WARN("dp aux hw did not signal timeout!\n");
#undef C

	return status;
--
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux