== Series Details == Series: series starting with [01/13] drm/i915: Suppress the "Failed to idle" warning for gem_eio URL : https://patchwork.freedesktop.org/series/57742/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4dedd46a945e drm/i915: Suppress the "Failed to idle" warning for gem_eio -:21: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #21: Reference: 5861b013e2c7 ("drm/i915: Do a synchronous switch-to-kernel-context on idling") -:21: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 5861b013e2c7 ("drm/i915: Do a synchronous switch-to-kernel-context on idling")' #21: Reference: 5861b013e2c7 ("drm/i915: Do a synchronous switch-to-kernel-context on idling") total: 1 errors, 1 warnings, 0 checks, 16 lines checked c04c584b0234 drm/i915: Introduce the i915_user_extension_method -:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 -:63: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #63: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1: +/* -:112: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #112: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1: +/* -:140: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects? #140: FILE: drivers/gpu/drm/i915/i915_utils.h:108: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:140: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #140: FILE: drivers/gpu/drm/i915/i915_utils.h:108: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:140: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues #140: FILE: drivers/gpu/drm/i915/i915_utils.h:108: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) total: 0 errors, 3 warnings, 3 checks, 109 lines checked 7b994f43e7c4 drm/i915: Introduce a context barrier callback b24cfcf439bd drm/i915: Create/destroy VM (ppGTT) for use with contexts -:40: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #40: FILE: drivers/gpu/drm/i915/i915_drv.h:221: + struct mutex vm_lock; -:551: WARNING:LINE_SPACING: Missing a blank line after declarations #551: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:503: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:613: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #613: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:565: + ncontexts = dw = 0; -:688: WARNING:LINE_SPACING: Missing a blank line after declarations #688: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:633: + struct i915_gem_context *ctx = NULL; + IGT_TIMEOUT(end_time); -:746: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #746: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:686: + ncontexts = dw = 0; -:853: WARNING:LONG_LINE: line over 100 characters #853: FILE: include/uapi/drm/i915_drm.h:405: +#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control) -:854: WARNING:LONG_LINE: line over 100 characters #854: FILE: include/uapi/drm/i915_drm.h:406: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:854: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #854: FILE: include/uapi/drm/i915_drm.h:406: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:854: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #854: FILE: include/uapi/drm/i915_drm.h:406: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) total: 1 errors, 5 warnings, 3 checks, 809 lines checked 821206137812 drm/i915: Extend CONTEXT_CREATE to set parameters upon construction -:28: WARNING:LONG_LINE: line over 100 characters #28: FILE: drivers/gpu/drm/i915/i915_drv.c:3113: + DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT, i915_gem_context_create_ioctl, DRM_RENDER_ALLOW), -:535: WARNING:LONG_LINE: line over 100 characters #535: FILE: include/uapi/drm/i915_drm.h:395: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:535: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #535: FILE: include/uapi/drm/i915_drm.h:395: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:535: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #535: FILE: include/uapi/drm/i915_drm.h:395: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) total: 1 errors, 3 warnings, 0 checks, 680 lines checked fa2d02c9d176 drm/i915: Allow contexts to share a single timeline across all engines 045e92a606a6 drm/i915: Allow userspace to clone contexts on creation a2eea5288054 drm/i915: Allow a context to define its set of engines cd2cecf7bc25 drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[] d1b97ccd96c6 drm/i915: Load balancing across a virtual engine -:914: WARNING:LINE_SPACING: Missing a blank line after declarations #914: FILE: drivers/gpu/drm/i915/intel_lrc.c:3347: + struct intel_engine_cs *actual = ve->siblings[0]; + virtual_engine_free(&ve->kref); total: 0 errors, 1 warnings, 0 checks, 1126 lines checked 27b55d0ef7aa drm/i915: Extend execution fence to support a callback 0ece4182687d drm/i915/execlists: Virtual engine bonding 9103b86a1051 drm/i915: Allow specification of parallel execbuf _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx