== Series Details == Series: series starting with [CI,1/7] drm/i915: Track active engines within a context URL : https://patchwork.freedesktop.org/series/57735/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1f077e3f067d drm/i915: Track active engines within a context -:111: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #111: FILE: drivers/gpu/drm/i915/i915_gem_context.h:167: + struct mutex mutex; total: 0 errors, 0 warnings, 1 checks, 198 lines checked 3419801ef9dc drm/i915: Split struct intel_context definition to its own header -:313: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #313: new file mode 100644 -:318: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #318: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:1: +/* -:447: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #447: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:130: + struct mutex mutex; -:588: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #588: FILE: drivers/gpu/drm/i915/i915_timeline_types.h:1: +/* -:612: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #612: FILE: drivers/gpu/drm/i915/i915_timeline_types.h:25: + spinlock_t lock; -:674: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #674: FILE: drivers/gpu/drm/i915/intel_context.h:1: +/* -:727: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #727: FILE: drivers/gpu/drm/i915/intel_context_types.h:1: +/* -:793: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #793: FILE: drivers/gpu/drm/i915/intel_engine_types.h:1: +/* -:1081: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #1081: FILE: drivers/gpu/drm/i915/intel_engine_types.h:289: + spinlock_t irq_lock; -:1297: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible side-effects? #1297: FILE: drivers/gpu/drm/i915/intel_engine_types.h:505: +#define instdone_slice_mask(dev_priv__) \ + (IS_GEN(dev_priv__, 7) ? \ + 1 : RUNTIME_INFO(dev_priv__)->sseu.slice_mask) -:1301: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible side-effects? #1301: FILE: drivers/gpu/drm/i915/intel_engine_types.h:509: +#define instdone_subslice_mask(dev_priv__) \ + (IS_GEN(dev_priv__, 7) ? \ + 1 : RUNTIME_INFO(dev_priv__)->sseu.subslice_mask[0]) -:1305: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible side-effects? #1305: FILE: drivers/gpu/drm/i915/intel_engine_types.h:513: +#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \ + for ((slice__) = 0, (subslice__) = 0; \ + (slice__) < I915_MAX_SLICES; \ + (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ + (slice__) += ((subslice__) == 0)) \ + for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ + (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) -:1305: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice__' - possible side-effects? #1305: FILE: drivers/gpu/drm/i915/intel_engine_types.h:513: +#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \ + for ((slice__) = 0, (subslice__) = 0; \ + (slice__) < I915_MAX_SLICES; \ + (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ + (slice__) += ((subslice__) == 0)) \ + for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ + (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) -:1305: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible side-effects? #1305: FILE: drivers/gpu/drm/i915/intel_engine_types.h:513: +#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \ + for ((slice__) = 0, (subslice__) = 0; \ + (slice__) < I915_MAX_SLICES; \ + (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ + (slice__) += ((subslice__) == 0)) \ + for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ + (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) -:1887: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1887: FILE: drivers/gpu/drm/i915/intel_workarounds_types.h:1: +/* -:1920: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1920: FILE: drivers/gpu/drm/i915/test_i915_active_types_standalone.c:1: +/* -:1933: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1933: FILE: drivers/gpu/drm/i915/test_i915_gem_context_types_standalone.c:1: +/* -:1946: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1946: FILE: drivers/gpu/drm/i915/test_i915_timeline_types_standalone.c:1: +/* -:1959: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1959: FILE: drivers/gpu/drm/i915/test_intel_context_types_standalone.c:1: +/* -:1972: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1972: FILE: drivers/gpu/drm/i915/test_intel_engine_types_standalone.c:1: +/* -:1985: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1985: FILE: drivers/gpu/drm/i915/test_intel_workarounds_types_standalone.c:1: +/* total: 0 errors, 13 warnings, 8 checks, 1866 lines checked 53b9ea58f97f drm/i915: Store the intel_context_ops in the intel_engine_cs ad0c65aea573 drm/i915: Move over to intel_context_lookup() -:270: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #270: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:145: + spinlock_t hw_contexts_lock; -:332: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #332: new file mode 100644 -:337: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #337: FILE: drivers/gpu/drm/i915/intel_context.c:1: +/* total: 0 errors, 2 warnings, 1 checks, 697 lines checked 61e30a289248 drm/i915: Make context pinning part of intel_context_ops 485a7aa0e463 drm/i915: Track the pinned kernel contexts on each engine 68c6382fa04c drm/i915: Introduce intel_context.pin_mutex for pin management -:254: WARNING:MEMORY_BARRIER: memory barrier without comment #254: FILE: drivers/gpu/drm/i915/intel_context.c:175: + smp_mb__before_atomic(); total: 0 errors, 1 warnings, 0 checks, 385 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
