Hi, > -----Original Message----- > From: Intel-gfx [mailto:intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx] On Behalf Of > Rodrigo Vivi > Sent: keskiviikko 6. maaliskuuta 2019 1.22 > To: Souza, Jose <jose.souza@xxxxxxxxx> > Cc: Nikula, Jani <jani.nikula@xxxxxxxxx>; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; Zanoni, > Paulo R <paulo.r.zanoni@xxxxxxxxx> > Subject: Re: [PATCH] drm/i915/icl: Remove alpha support protection > > On Tue, Mar 05, 2019 at 02:11:53PM -0800, José Roberto de Souza wrote: > > Now with the watermarks fixes merged, Icelake is stable enough to have > > the alpha support protection flag removed. > > > > We have a few ICL machines in our CI and it is mostly green with > > failures in tests that will not impact future linux installations. > > Also there is no warnings, errors, flickering or any visual defects > > while doing ordinary tasks like browsing and editing documents in a > > dual monitor setup. > > > > As a reminder i915.alpha_support was created to protect future linux > > installation's iso images that might contain a kernel from the > > enabling time of the new platform. Without this protection most of > > linux installation was recommending nomodeset option during > > installation that was getting stick there after installation. > > > > Specifically, alpha support says nothing about the development state > > of the hardware, and everything about the state of the driver in a > > kernel release. > > > > This is semantically no different from the old preliminary_hw_support > > flag, but the old one was all too often interpreted as (preliminary > > hw) support instead of the intended > > (preliminary) hw support, and it was misleading for everyone. > > Hence the rename. > > > > Reference: https://intel-gfx-ci.01.org/tree/drm-tip/fi-icl-y.html > > This view is great. It is unfortunate we cannot save this and this link will be invalid in > few runs. > > > Reference: https://intel-gfx-ci.01.org/tree/drm-tip/shard-iclb.html > > This picture doesn't help, but taking your word, and the BAT results and quoting Jani > Saarinen: "Nice improvement here what comes to passes..." > > Old: f2-icl-u total:262 pass:107 dwarn:98 dfail:0 fail:1 skip:55 time:429s > f2-icl-u total:263 pass:222 dwarn:9 dfail:0 fail:3 skip:29 time:339s > > Old: f2-icl-y total:262 pass:105 dwarn:98 dfail:0 fail:4 skip:54 time:430s > f2-icl-y total:476 pass:225 dwarn:7 dfail:0 fail:4 skip:240 time:470s > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> Acked-by: Jani Saarinen <jani.saarinen@xxxxxxxxx> > > > Cc: James Ausmus <james.ausmus@xxxxxxxxx> > > Cc: Jani Saarinen <jani.saarinen@xxxxxxxxx> > > Cc: Paulo Zanoni <paulo.r.zanoni@xxxxxxxxx> > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > > Cc: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/i915_pci.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_pci.c > > b/drivers/gpu/drm/i915/i915_pci.c index c42c5ccf38fe..527bd1ceb9ac > > 100644 > > --- a/drivers/gpu/drm/i915/i915_pci.c > > +++ b/drivers/gpu/drm/i915/i915_pci.c > > @@ -658,7 +658,6 @@ static const struct intel_device_info > > intel_cannonlake_info = { static const struct intel_device_info > intel_icelake_11_info = { > > GEN11_FEATURES, > > PLATFORM(INTEL_ICELAKE), > > - .is_alpha_support = 1, > > .engine_mask = > > BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2), }; > > -- > > 2.21.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
