On Tue, 2019-03-05 at 22:47 -0800, José Roberto de Souza wrote: > The support for PSR2 was polished, IGT tests for PSR2 was added and > it was tested performing regular user workloads like browsing, > editing documents and compiling Linux, so it is time to enable it by > default and enjoy even more power-savings. Great job :) Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> Is there a reason to include the PSR1 CRC fix in this series, that is an orthogonal issue IMO. And I think we should merge the PSR2 patches independently. > > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@xxxxxxxxx> > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx> > Signed-off-by: José Roberto de Souza <jose.souza@xxxxxxxxx> > --- > drivers/gpu/drm/i915/intel_psr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_psr.c > b/drivers/gpu/drm/i915/intel_psr.c > index 5d66e7313c75..bae266869c20 100644 > --- a/drivers/gpu/drm/i915/intel_psr.c > +++ b/drivers/gpu/drm/i915/intel_psr.c > @@ -80,9 +80,6 @@ static bool intel_psr2_enabled(struct > drm_i915_private *dev_priv, > case I915_PSR_DEBUG_DISABLE: > case I915_PSR_DEBUG_FORCE_PSR1: > return false; > - case I915_PSR_DEBUG_DEFAULT: > - if (i915_modparams.enable_psr <= 0) > - return false; > default: > return crtc_state->has_psr2; > } _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
