Quoting Matthew Auld (2019-03-06 17:05:47)
> On 06/03/2019 14:25, Chris Wilson wrote:
> > Split the plain old shmem object into its own file to start decluttering
> > i915_gem.c
> >
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>
> [snip]
>
> > +
> > +const struct drm_i915_gem_object_ops i915_gem_shmem_ops = {
> > + .flags = I915_GEM_OBJECT_HAS_STRUCT_PAGE |
> > + I915_GEM_OBJECT_IS_SHRINKABLE,
> > +
> > + .get_pages = shmem_get_pages_gtt,
> > + .put_pages = shmem_put_pages_gtt,
> > +
> > + .pwrite = shmem_pwrite_gtt,
>
> I never really understood the _gtt thing here...maybe because of the
> prepare_gtt?
Historical accident, and prepare_gtt is pretty much the reason why, but
mostly I recall it being !phys. I guess now would be a perfect time to
add a drop of consistency and drop the _gtt suffix.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
