Quoting Tvrtko Ursulin (2019-03-05 16:19:12)
>
> On 01/03/2019 14:03, Chris Wilson wrote:
> > This complex struct pulling in half the driver deserves its own
> > isolation in preparation for intel_context becoming an outright
> > complicated class of its own.
> >
> > In order to split this beast into its own header also requests splitting
> > several of its dependent types and their dependencies into their own
> > headers as well.
>
> I don't feel like I need to read this one in detail. If it compiles it
> should be good.
Hmm, one thing I started doing for the next series is
# Test the headers are compilable as standalone units
i915-$(CONFIG_DRM_I915_WERROR) += \
gem/test_i915_gemfs_standalone.o \
gem/test_i915_gem_clflush_standalone.o \
gem/test_i915_gem_context_standalone.o \
gem/test_i915_gem_context_types_standalone.o \
gem/test_i915_gem_ioctls_standalone.o \
gem/test_i915_gem_object_standalone.o \
gem/test_i915_gem_object_types_standalone.o
which would be good here as it helps with those fuzzy feelings that the
compiler is doing all the checking.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
