== Series Details == Series: series starting with [01/38] drm/i915/execlists: Suppress redundant preemption URL : https://patchwork.freedesktop.org/series/57427/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5e23d902d35d drm/i915/execlists: Suppress redundant preemption 2bf4e3894cc3 drm/i915: Introduce i915_timeline.mutex bf3a70770514 drm/i915: Keep timeline HWSP allocated until idle across the system 183c1d46d005 drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+ f1ab995ada5f drm/i915: Prioritise non-busywait semaphore workloads 7da75240f892 drm/i915/selftests: Check that whitelisted registers are accessible fb6dd69a3faf drm/i915: Force GPU idle on suspend bd82e2da337c drm/i915/selftests: Improve switch-to-kernel-context checking c3674ddd02ad drm/i915: Do a synchronous switch-to-kernel-context on idling e210c30d893c drm/i915: Store the BIT(engine->id) as the engine's mask -:262: CHECK:SPACING: No space is necessary after a cast #262: FILE: drivers/gpu/drm/i915/intel_device_info.c:741: + BUILD_BUG_ON(BITS_PER_TYPE(intel_engine_mask_t) < I915_NUM_ENGINES); total: 0 errors, 0 warnings, 1 checks, 520 lines checked 40c040d7f36a drm/i915: Refactor common code to load initial power context 3344a6270d75 drm/i915: Reduce presumption of request ordering for barriers 0fbe8b734da4 drm/i915: Remove has-kernel-context 14c910b68d83 drm/i915: Introduce the i915_user_extension_method -:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #58: new file mode 100644 -:63: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #63: FILE: drivers/gpu/drm/i915/i915_user_extensions.c:1: +/* -:112: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #112: FILE: drivers/gpu/drm/i915/i915_user_extensions.h:1: +/* -:140: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects? #140: FILE: drivers/gpu/drm/i915/i915_utils.h:108: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:140: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'member' - possible side-effects? #140: FILE: drivers/gpu/drm/i915/i915_utils.h:108: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) -:140: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'member' may be better as '(member)' to avoid precedence issues #140: FILE: drivers/gpu/drm/i915/i915_utils.h:108: +#define container_of_user(ptr, type, member) ({ \ + void __user *__mptr = (void __user *)(ptr); \ + BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \ + !__same_type(*(ptr), void), \ + "pointer type mismatch in container_of()"); \ + ((type __user *)(__mptr - offsetof(type, member))); }) total: 0 errors, 3 warnings, 3 checks, 109 lines checked 0b25c64b182f drm/i915: Track active engines within a context -:110: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #110: FILE: drivers/gpu/drm/i915/i915_gem_context.h:167: + struct mutex mutex; total: 0 errors, 0 warnings, 1 checks, 198 lines checked 0baaabfdc6c8 drm/i915: Introduce a context barrier callback f8ec2c8c0830 drm/i915: Create/destroy VM (ppGTT) for use with contexts -:37: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #37: FILE: drivers/gpu/drm/i915/i915_drv.h:221: + struct mutex vm_lock; -:551: WARNING:LINE_SPACING: Missing a blank line after declarations #551: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:503: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:627: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #627: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:565: + ncontexts = dw = 0; -:678: WARNING:LINE_SPACING: Missing a blank line after declarations #678: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:610: + struct drm_file *file; + IGT_TIMEOUT(end_time); -:758: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #758: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:686: + ncontexts = dw = 0; -:876: WARNING:LONG_LINE: line over 100 characters #876: FILE: include/uapi/drm/i915_drm.h:405: +#define DRM_IOCTL_I915_GEM_VM_CREATE DRM_IOWR(DRM_COMMAND_BASE + DRM_I915_GEM_VM_CREATE, struct drm_i915_gem_vm_control) -:877: WARNING:LONG_LINE: line over 100 characters #877: FILE: include/uapi/drm/i915_drm.h:406: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:877: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #877: FILE: include/uapi/drm/i915_drm.h:406: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) -:877: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #877: FILE: include/uapi/drm/i915_drm.h:406: +#define DRM_IOCTL_I915_GEM_VM_DESTROY DRM_IOW (DRM_COMMAND_BASE + DRM_I915_GEM_VM_DESTROY, struct drm_i915_gem_vm_control) total: 1 errors, 5 warnings, 3 checks, 834 lines checked efcf633f1dbb drm/i915: Extend CONTEXT_CREATE to set parameters upon construction -:27: WARNING:LONG_LINE: line over 100 characters #27: FILE: drivers/gpu/drm/i915/i915_drv.c:3000: + DRM_IOCTL_DEF_DRV(I915_GEM_CONTEXT_CREATE_EXT, i915_gem_context_create_ioctl, DRM_RENDER_ALLOW), -:542: WARNING:LONG_LINE: line over 100 characters #542: FILE: include/uapi/drm/i915_drm.h:395: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:542: WARNING:SPACING: space prohibited between function name and open parenthesis '(' #542: FILE: include/uapi/drm/i915_drm.h:395: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) -:542: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #542: FILE: include/uapi/drm/i915_drm.h:395: +#define DRM_IOCTL_I915_GEM_CONTEXT_CREATE_EXT DRM_IOWR (DRM_COMMAND_BASE + DRM_I915_GEM_CONTEXT_CREATE, struct drm_i915_gem_context_create_ext) total: 1 errors, 3 warnings, 0 checks, 688 lines checked 2e12e535df62 drm/i915: Allow contexts to share a single timeline across all engines 4b3dbd308a4d drm/i915: Allow userspace to clone contexts on creation 5aae2005f1de drm/i915: Fix I915_EXEC_RING_MASK e7c03aa42717 drm/i915: Remove last traces of exec-id (GEM_BUSY) fa712cd9fcd4 drm/i915: Re-arrange execbuf so context is known before engine 481ec94ce3cc drm/i915: Allow a context to define its set of engines 40e466b00076 drm/i915: Extend I915_CONTEXT_PARAM_SSEU to support local ctx->engine[] ae2d6298740e drm/i915: Pass around the intel_context 53195d9716e1 drm/i915: Split struct intel_context definition to its own header -:297: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #297: new file mode 100644 -:302: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #302: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:1: +/* -:437: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment #437: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:136: + struct mutex mutex; -:472: CHECK:LINE_SPACING: Please don't use multiple blank lines #472: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:171: + + -:579: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #579: FILE: drivers/gpu/drm/i915/i915_timeline_types.h:1: +/* -:603: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #603: FILE: drivers/gpu/drm/i915/i915_timeline_types.h:25: + spinlock_t lock; -:665: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #665: FILE: drivers/gpu/drm/i915/intel_context.h:1: +/* -:718: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #718: FILE: drivers/gpu/drm/i915/intel_context_types.h:1: +/* -:784: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #784: FILE: drivers/gpu/drm/i915/intel_engine_types.h:1: +/* -:1072: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #1072: FILE: drivers/gpu/drm/i915/intel_engine_types.h:289: + spinlock_t irq_lock; -:1288: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible side-effects? #1288: FILE: drivers/gpu/drm/i915/intel_engine_types.h:505: +#define instdone_slice_mask(dev_priv__) \ + (IS_GEN(dev_priv__, 7) ? \ + 1 : RUNTIME_INFO(dev_priv__)->sseu.slice_mask) -:1292: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible side-effects? #1292: FILE: drivers/gpu/drm/i915/intel_engine_types.h:509: +#define instdone_subslice_mask(dev_priv__) \ + (IS_GEN(dev_priv__, 7) ? \ + 1 : RUNTIME_INFO(dev_priv__)->sseu.subslice_mask[0]) -:1296: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv__' - possible side-effects? #1296: FILE: drivers/gpu/drm/i915/intel_engine_types.h:513: +#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \ + for ((slice__) = 0, (subslice__) = 0; \ + (slice__) < I915_MAX_SLICES; \ + (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ + (slice__) += ((subslice__) == 0)) \ + for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ + (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) -:1296: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'slice__' - possible side-effects? #1296: FILE: drivers/gpu/drm/i915/intel_engine_types.h:513: +#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \ + for ((slice__) = 0, (subslice__) = 0; \ + (slice__) < I915_MAX_SLICES; \ + (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ + (slice__) += ((subslice__) == 0)) \ + for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ + (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) -:1296: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'subslice__' - possible side-effects? #1296: FILE: drivers/gpu/drm/i915/intel_engine_types.h:513: +#define for_each_instdone_slice_subslice(dev_priv__, slice__, subslice__) \ + for ((slice__) = 0, (subslice__) = 0; \ + (slice__) < I915_MAX_SLICES; \ + (subslice__) = ((subslice__) + 1) < I915_MAX_SUBSLICES ? (subslice__) + 1 : 0, \ + (slice__) += ((subslice__) == 0)) \ + for_each_if((BIT(slice__) & instdone_slice_mask(dev_priv__)) && \ + (BIT(subslice__) & instdone_subslice_mask(dev_priv__))) -:1878: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #1878: FILE: drivers/gpu/drm/i915/intel_workarounds_types.h:1: +/* total: 0 errors, 7 warnings, 9 checks, 1821 lines checked c34e28878e18 drm/i915: Store the intel_context_ops in the intel_engine_cs b2525b1af2fa drm/i915: Move over to intel_context_lookup() -:286: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment #286: FILE: drivers/gpu/drm/i915/i915_gem_context_types.h:151: + spinlock_t hw_contexts_lock; -:324: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #324: new file mode 100644 -:329: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1 #329: FILE: drivers/gpu/drm/i915/intel_context.c:1: +/* total: 0 errors, 2 warnings, 1 checks, 647 lines checked 631bd21a494b drm/i915: Make context pinning part of intel_context_ops b8e8c0a9719d drm/i915: Track the pinned kernel contexts on each engine 6ccc7beebb9c drm/i915: Introduce intel_context.pin_mutex for pin management -:243: WARNING:MEMORY_BARRIER: memory barrier without comment #243: FILE: drivers/gpu/drm/i915/intel_context.c:157: + smp_mb__before_atomic(); total: 0 errors, 1 warnings, 0 checks, 387 lines checked 9a20e5c80942 drm/i915: Load balancing across a virtual engine -:900: WARNING:LINE_SPACING: Missing a blank line after declarations #900: FILE: drivers/gpu/drm/i915/intel_lrc.c:3342: + struct intel_engine_cs *actual = ve->siblings[0]; + virtual_engine_free(&ve->kref); total: 0 errors, 1 warnings, 0 checks, 1108 lines checked eb7f9c7d8fed drm/i915: Extend execution fence to support a callback 43190fadc3e7 drm/i915/execlists: Virtual engine bonding 7988f06b0790 drm/i915: Allow specification of parallel execbuf 3b2bef0b3c17 drm/i915/selftests: Check preemption support on each engine 800b0544e514 drm/i915/execlists: Skip direct submission if only lite-restore _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
