✗ Fi.CI.CHECKPATCH: warning for drm & vgaarb: handle vgacon removal in vgaarb. (rev2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: drm & vgaarb: handle vgacon removal in vgaarb. (rev2)
URL   : https://patchwork.freedesktop.org/series/57086/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bfa4e81d85e2 drm: move i915_kick_out_vgacon to vgaarb
-:94: ERROR:CODE_INDENT: code indent should use tabs where possible
#94: FILE: drivers/gpu/vga/vgaarb.c:186:
+        return 0;$

-:94: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#94: FILE: drivers/gpu/vga/vgaarb.c:186:
+        return 0;$

-:99: ERROR:CODE_INDENT: code indent should use tabs where possible
#99: FILE: drivers/gpu/vga/vgaarb.c:191:
+        return -ENODEV;$

-:99: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#99: FILE: drivers/gpu/vga/vgaarb.c:191:
+        return -ENODEV;$

-:104: ERROR:CODE_INDENT: code indent should use tabs where possible
#104: FILE: drivers/gpu/vga/vgaarb.c:196:
+        int ret = 0;$

-:104: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#104: FILE: drivers/gpu/vga/vgaarb.c:196:
+        int ret = 0;$

-:110: ERROR:CODE_INDENT: code indent should use tabs where possible
#110: FILE: drivers/gpu/vga/vgaarb.c:202:
+        console_lock();$

-:110: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#110: FILE: drivers/gpu/vga/vgaarb.c:202:
+        console_lock();$

-:111: ERROR:CODE_INDENT: code indent should use tabs where possible
#111: FILE: drivers/gpu/vga/vgaarb.c:203:
+        if (con_is_bound(&vga_con))$

-:111: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#111: FILE: drivers/gpu/vga/vgaarb.c:203:
+        if (con_is_bound(&vga_con))$

-:112: ERROR:CODE_INDENT: code indent should use tabs where possible
#112: FILE: drivers/gpu/vga/vgaarb.c:204:
+                ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);$

-:112: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#112: FILE: drivers/gpu/vga/vgaarb.c:204:
+                ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, 1);$

-:113: ERROR:CODE_INDENT: code indent should use tabs where possible
#113: FILE: drivers/gpu/vga/vgaarb.c:205:
+        if (ret == 0) {$

-:113: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#113: FILE: drivers/gpu/vga/vgaarb.c:205:
+        if (ret == 0) {$

-:114: ERROR:CODE_INDENT: code indent should use tabs where possible
#114: FILE: drivers/gpu/vga/vgaarb.c:206:
+                ret = do_unregister_con_driver(&vga_con);$

-:114: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#114: FILE: drivers/gpu/vga/vgaarb.c:206:
+                ret = do_unregister_con_driver(&vga_con);$

-:116: ERROR:CODE_INDENT: code indent should use tabs where possible
#116: FILE: drivers/gpu/vga/vgaarb.c:208:
+                /* Ignore "already unregistered". */$

-:117: ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: drivers/gpu/vga/vgaarb.c:209:
+                if (ret == -ENODEV)$

-:117: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: drivers/gpu/vga/vgaarb.c:209:
+                if (ret == -ENODEV)$

-:118: ERROR:CODE_INDENT: code indent should use tabs where possible
#118: FILE: drivers/gpu/vga/vgaarb.c:210:
+                        ret = 0;$

-:118: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#118: FILE: drivers/gpu/vga/vgaarb.c:210:
+                        ret = 0;$

-:119: ERROR:CODE_INDENT: code indent should use tabs where possible
#119: FILE: drivers/gpu/vga/vgaarb.c:211:
+        }$

-:119: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#119: FILE: drivers/gpu/vga/vgaarb.c:211:
+        }$

-:120: ERROR:CODE_INDENT: code indent should use tabs where possible
#120: FILE: drivers/gpu/vga/vgaarb.c:212:
+        console_unlock();$

-:120: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#120: FILE: drivers/gpu/vga/vgaarb.c:212:
+        console_unlock();$

-:122: ERROR:CODE_INDENT: code indent should use tabs where possible
#122: FILE: drivers/gpu/vga/vgaarb.c:214:
+        return ret;$

-:122: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#122: FILE: drivers/gpu/vga/vgaarb.c:214:
+        return ret;$

-:138: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#138: FILE: include/linux/vgaarb.h:128:
+extern int vga_remove_vgacon(struct pci_dev *pdev);

total: 14 errors, 13 warnings, 1 checks, 118 lines checked
c0c659536670 drm/fb-helper: call vga_remove_vgacon automatically.
555ec02d6c8f drm/qxl: remove conflicting framebuffers earlier

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux