Quoting Antonio Argenziano (2019-02-21 16:08:04) > > > On 21/02/19 02:19, Chris Wilson wrote: > > To control hang detection, we manipulate the i915.reset module > > parameter. However, to be nice we should SKIP if we cannot modify the > > parameter as opposed to outright FAILing. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=108891 > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > --- > > lib/igt_gt.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/lib/igt_gt.c b/lib/igt_gt.c > > index 646696727..c98a7553b 100644 > > --- a/lib/igt_gt.c > > +++ b/lib/igt_gt.c > > @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags) > > if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false)) > > igt_require(has_gpu_reset(fd)); > > > > - igt_assert(igt_sysfs_set_parameter > > - (fd, "reset", "%d", INT_MAX /* any reset method */)); > > + igt_require(igt_sysfs_set_parameter > > + (fd, "reset", "%d", INT_MAX /* any reset method */)); > > How come we were not able to write that parameter? Isn't that sysfs > always there? No. It can be compiled out. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
