On Thu, Feb 21, 2019 at 04:09:12PM +0100, Gerd Hoffmann wrote: > > > +int drm_fb_helper_kick_out_vgacon(void); > > > + > > > > Don't you need a dummy version as well for this one, like how it's done > > for the other functions, to cover the case when DRM_FBDEV_EMULATION is > > not selected? > > Good question. > > I guess it makes sense to kick out vgacon even with CONFIG_FB=n. > > But when integrating this into > drm_fb_helper_remove_conflicting_pci_framebuffers() as suggested by > Daniel this isn't going to fly ... We need to put it into both versions of that function, or pull that function out of the #ifdef. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
