Quoting Tvrtko Ursulin (2019-02-11 18:44:50)
>
> On 06/02/2019 13:03, Chris Wilson wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> > index a674c78ca1f8..8792ad12373d 100644
> > --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> > @@ -380,19 +380,16 @@ static void print_error_buffers(struct drm_i915_error_state_buf *m,
> > err_printf(m, "%s [%d]:\n", name, count);
> >
> > while (count--) {
> > - err_printf(m, " %08x_%08x %8u %02x %02x %02x",
> > + err_printf(m, " %08x_%08x %8u %02x %02x",
> > upper_32_bits(err->gtt_offset),
> > lower_32_bits(err->gtt_offset),
> > err->size,
> > err->read_domains,
> > - err->write_domain,
> > - err->wseqno);
> > + err->write_domain);
> > err_puts(m, tiling_flag(err->tiling));
> > err_puts(m, dirty_flag(err->dirty));
> > err_puts(m, purgeable_flag(err->purgeable));
> > err_puts(m, err->userptr ? " userptr" : "");
> > - err_puts(m, err->engine != -1 ? " " : "");
> > - err_puts(m, engine_name(m->i915, err->engine));
>
> Why remove this information?
Because I don't like it. Having removed the global write seqno tracking,
the concept is defunct. The information that we need to present, if
anyone actually cared, would be the obj->resv.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
