Re: [PATCH 2/2] drm/i915: Use synchronize_srcu_expedited() for resets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes:

> We impose upon ourselves a strict timeout for resets (to ensure forward
> progress by use of a failsafe). Prefer to use the expedited
> synchronisation function in this case to reduce the likelihood of a
> spurious delay being treated as a deadlock.

5 seconds of spurious delay?

Well, better to rule this one out,

Reviewed-by: Mika Kuoppala <mika.kuoppala@xxxxxxxxxxxxxxx>

>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Mika Kuoppala <mika.kuoppala@xxxxxxxxx>
> ---
>  drivers/gpu/drm/i915/i915_reset.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reset.c b/drivers/gpu/drm/i915/i915_reset.c
> index c2b7570730c2..c1b53533ada6 100644
> --- a/drivers/gpu/drm/i915/i915_reset.c
> +++ b/drivers/gpu/drm/i915/i915_reset.c
> @@ -1138,7 +1138,7 @@ static void i915_reset_device(struct drm_i915_private *i915,
>  		intel_prepare_reset(i915);
>  
>  		/* Flush everyone using a resource about to be clobbered */
> -		synchronize_srcu(&error->reset_backoff_srcu);
> +		synchronize_srcu_expedited(&error->reset_backoff_srcu);
>  
>  		mutex_lock(&error->wedge_mutex);
>  		i915_reset(i915, engine_mask, reason);
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux