Re: [IGT 2/2] tools/intel_gpu_top: Add file output capability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Tvrtko Ursulin (2019-02-08 12:03:51)
> From: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> 
> A new -o command switch enables logging to a file.
> 
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108689
> Cc: Eero Tamminen <eero.t.tamminen@xxxxxxxxx>
> Cc: 3.14pi@xxxxxxx
> Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

> -       if (output_mode == INTERACTIVE && isatty(1) != 1)
> +       if (output_mode == INTERACTIVE && (output_path || isatty(1) != 1))
>                 output_mode = STDOUT;
>  
> +       if (output_path) {

if (output_path && strcmp(output_path, "-")) { ?

"-o -" is common enough for forcing output even on the terminal.

Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux