✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: series starting with [01/22] drm/i915/execlists: Suppress mere WAIT preemption
URL   : https://patchwork.freedesktop.org/series/56183/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2003a826bcc9 drm/i915/execlists: Suppress mere WAIT preemption
4ea55b47b679 drm/i915/execlists: Suppress redundant preemption
057170380bc2 drm/i915/selftests: Exercise some AB...BA preemption chains
075b40c8a703 drm/i915: Trim NEWCLIENT boosting
770fc9436462 drm/i915: Show support for accurate sw PMU busyness tracking
fc011ccbf2e1 drm/i915: Revoke mmaps and prevent access to fence registers across reset
5ba03f59e64e drm/i915: Force the GPU reset upon wedging
5fc92d0ac60e drm/i915: Uninterruptibly drain the timelines on unwedging
2054755a2346 drm/i915: Wait for old resets before applying debugfs/i915_wedged
3f8a64bf2876 drm/i915: Serialise resets with wedging
c2307ce3ed5b drm/i915: Don't claim an unstarted request was guilty
f524044f24ff drm/i915: Generalise GPU activity tracking
-:31: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
new file mode 100644

-:36: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#36: FILE: drivers/gpu/drm/i915/i915_active.c:1:
+/*

-:270: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#270: FILE: drivers/gpu/drm/i915/i915_active.h:1:
+/*

-:345: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#345: FILE: drivers/gpu/drm/i915/i915_active_types.h:1:
+/*

-:700: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#700: FILE: drivers/gpu/drm/i915/selftests/i915_active.c:1:
+/*

total: 0 errors, 5 warnings, 0 checks, 798 lines checked
02cb9e1dad1c drm/i915: Release the active tracker tree upon idling
6131355f9bde drm/i915: Allocate active tracking nodes from a slabcache
6e02a325bf2e drm/i915: Make request allocation caches global
-:158: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#158: 
new file mode 100644

-:163: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#163: FILE: drivers/gpu/drm/i915/i915_globals.c:1:
+/*

-:218: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#218: FILE: drivers/gpu/drm/i915/i915_globals.h:1:
+/*

-:558: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#558: FILE: drivers/gpu/drm/i915/i915_scheduler.h:95:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:558: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#558: FILE: drivers/gpu/drm/i915/i915_scheduler.h:95:
+#define priolist_for_each_request(it, plist, idx) \
+	for (idx = 0; idx < ARRAY_SIZE((plist)->requests); idx++) \
+		list_for_each_entry(it, &(plist)->requests[idx], sched.link)

-:562: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'plist' - possible side-effects?
#562: FILE: drivers/gpu/drm/i915/i915_scheduler.h:99:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

-:562: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'idx' - possible side-effects?
#562: FILE: drivers/gpu/drm/i915/i915_scheduler.h:99:
+#define priolist_for_each_request_consume(it, n, plist, idx) \
+	for (; (idx = ffs((plist)->used)); (plist)->used &= ~BIT(idx - 1)) \
+		list_for_each_entry_safe(it, n, \
+					 &(plist)->requests[idx - 1], \
+					 sched.link)

total: 0 errors, 3 warnings, 4 checks, 746 lines checked
74cb3e7eceba drm/i915: Add timeline barrier support
7072ed37f6b4 drm/i915: Pull i915_gem_active into the i915_active family
-:690: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#690: FILE: drivers/gpu/drm/i915/i915_gem_fence_reg.c:227:
+		ret = i915_active_request_retire(&vma->last_fence,
 					     &vma->obj->base.dev->struct_mutex);

-:699: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#699: FILE: drivers/gpu/drm/i915/i915_gem_fence_reg.c:236:
+		ret = i915_active_request_retire(&old->last_fence,
 					     &old->obj->base.dev->struct_mutex);

-:1408: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1408: FILE: drivers/gpu/drm/i915/i915_vma.c:990:
+		ret = i915_active_request_retire(&vma->last_fence,
+					      &vma->vm->i915->drm.struct_mutex);

total: 0 errors, 0 warnings, 3 checks, 1392 lines checked
fca21928c6b9 drm/i915: Keep timeline HWSP allocated until idle across the system
a68b8158d4d9 drm/i915/execlists: Refactor out can_merge_rq()
b08aeb9031a5 drm/i915: Use HW semaphores for inter-engine synchronisation on gen8+
-:326: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#326: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:109:
+#define   MI_SEMAPHORE_SAD_GT_SDD	(0<<12)
                                  	  ^

-:328: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#328: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:111:
+#define   MI_SEMAPHORE_SAD_LT_SDD	(2<<12)
                                  	  ^

-:329: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#329: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:112:
+#define   MI_SEMAPHORE_SAD_LTE_SDD	(3<<12)
                                   	  ^

-:330: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#330: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:113:
+#define   MI_SEMAPHORE_SAD_EQ_SDD	(4<<12)
                                  	  ^

-:331: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#331: FILE: drivers/gpu/drm/i915/intel_gpu_commands.h:114:
+#define   MI_SEMAPHORE_SAD_NEQ_SDD	(5<<12)
                                   	  ^

total: 0 errors, 0 warnings, 5 checks, 298 lines checked
842b32511f09 drm/i915: Prioritise non-busywait semaphore workloads
5d4fa7842268 semaphore-no-stats
-:20: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 7 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux