Re: [PATCH 1/5] drm/i915: Revoke mmaps and prevent access to fence registers across reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Chris,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20190131]
[cannot apply to v5.0-rc4]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-Revoke-mmaps-and-prevent-access-to-fence-registers-across-reset/20190201-043323
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_reset.c:1304:5: sparse: warning: context imbalance in 'i915_reset_lock' - different lock contexts for basic block
>> drivers/gpu/drm/i915/i915_reset.c:1325:6: sparse: warning: context imbalance in 'i915_reset_unlock' - unexpected unlock

vim +/i915_reset_lock +1304 drivers/gpu/drm/i915/i915_reset.c

  1303	
> 1304	int i915_reset_lock(struct drm_i915_private *i915)
  1305	{
  1306		int srcu;
  1307	
  1308		rcu_read_lock();
  1309		while (test_bit(I915_RESET_BACKOFF, &i915->gpu_error.flags)) {
  1310			rcu_read_unlock();
  1311	
  1312			if (wait_event_interruptible(i915->gpu_error.reset_queue,
  1313						     !test_bit(I915_RESET_BACKOFF,
  1314							       &i915->gpu_error.flags)))
  1315				return -EINTR;
  1316	
  1317			rcu_read_lock();
  1318		}
  1319		srcu = srcu_read_lock(&i915->gpu_error.srcu);
  1320		rcu_read_unlock();
  1321	
  1322		return srcu;
  1323	}
  1324	
> 1325	void i915_reset_unlock(struct drm_i915_private *i915, int tag)
  1326	{
  1327		srcu_read_unlock(&i915->gpu_error.srcu, tag);
  1328	}
  1329	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux